[net processing] Refactor MaybeSendAddr() - early exits
ClosedPublic
Actions

Authored by PiRK on Jan 27 2022, 16:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4521689ee985: [net processing] Refactor MaybeSendAddr() - early exits

Summary

Add early exit guard clauses if node.RelayAddrsWithConn() is false or if
current_time < node.m_next_addr_send. Add comments.

This is a backport of core#21236 [5/6]
https://github.com/bitcoin/bitcoin/pull/21236/commits/38c0be5da3af17208b165e73cee7612d3670b038
https://github.com/bitcoin/bitcoin/pull/21236/commits/01a79ff924b11f91796d4aa63c571897b047ac7d

Depends on D10918

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18039
Build 35900: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35899: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 27 2022, 16:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2022, 16:16

PiRK requested review of this revision.Jan 27 2022, 16:16

teamcity edited the summary of this revision. (Show Details)Jan 27 2022, 16:16

PiRK added a child revision: D10920: [net processing] Refactor MaybeSendAddr().Jan 27 2022, 16:17

add missing blank line

Fabien accepted this revision.Jan 27 2022, 16:59

This revision is now accepted and ready to land.Jan 27 2022, 16:59

Harbormaster completed remote builds in B18039: Diff 32020.Jan 27 2022, 17:07

Harbormaster completed remote builds in B18042: Diff 32023.Jan 27 2022, 17:26

Closed by commit rABC4521689ee985: [net processing] Refactor MaybeSendAddr() - early exits (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyJan 28 2022, 07:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4521689ee985: [net processing] Refactor MaybeSendAddr() - early exits.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

89 lines

Diff 32020

View Options

[net processing] Refactor MaybeSendAddr() - early exitsClosedPublicActions