Add logging and addr rate limiting statistics
AbandonedPublic
Actions

Authored by PiRK on Jan 31 2022, 10:47.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Includes logging improvements by Vasil Dimov and John Newbery.

This is a backport of core#22387 [4/5]
https://github.com/bitcoin/bitcoin/pull/22387/commits/f424d601e1b6870e20bc60f5ccba36d2e210377b

Depends on D10938

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18074
Build 35970: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35969: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 31 2022, 10:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2022, 10:47

PiRK requested review of this revision.Jan 31 2022, 10:47

teamcity edited the summary of this revision. (Show Details)Jan 31 2022, 10:47

PiRK added a child revision: D10940: Improve addr relay tests using statistics.Jan 31 2022, 10:53

Harbormaster completed remote builds in B18074: Diff 32076.Jan 31 2022, 11:01

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc-cmdline.py ======

------- Stdout: -------
2022-01-31T10:58:20.464000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220131_105746/abc-cmdline_8
2022-01-31T10:58:21.294000Z TestFramework (INFO): Testing -maxaddrtosend=10
2022-01-31T10:59:25.850000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2022-01-31T10:59:25.850000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/abc-cmdline.py", line 121, in run_test
    self.maxaddrtosend_test(max_addr_to_send)
  File "/work/test/functional/abc-cmdline.py", line 66, in maxaddrtosend_test
    peer.wait_until(peer.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 502, in wait_until
    timeout_factor=self.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 286, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2022-01-31T10:59:25.901000Z TestFramework (INFO): Stopping nodes
2022-01-31T10:59:27.308000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220131_105746/abc-cmdline_8
2022-01-31T10:59:27.308000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220131_105746/abc-cmdline_8/test_framework.log
2022-01-31T10:59:27.308000Z TestFramework (ERROR): 
2022-01-31T10:59:27.308000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220131_105746/abc-cmdline_8' to consolidate all logs
2022-01-31T10:59:27.308000Z TestFramework (ERROR): 
2022-01-31T10:59:27.309000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-01-31T10:59:27.309000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-01-31T10:59:27.309000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc-cmdline.py

squashed D10941