Remove m_is_manual_connection from CNodeState
ClosedPublic
Actions

Authored by PiRK on Feb 1 2022, 08:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC43a7ffb79d05: Remove m_is_manual_connection from CNodeState

Summary

Currently, this member is only used to exclude MANUAL peers from discouragement
in MaybePunishNodeForBlock(). Manual connections are already protected in
MaybeDiscourageAndDisconnect(), independently from their network
processing behaviors.

This is a backport of core#20617

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 1 2022, 08:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2022, 08:56

PiRK requested review of this revision.Feb 1 2022, 08:56

teamcity edited the summary of this revision. (Show Details)Feb 1 2022, 08:56

fix comment

Fabien accepted this revision.Feb 1 2022, 09:07

This revision is now accepted and ready to land.Feb 1 2022, 09:07

Harbormaster completed remote builds in B18090: Diff 32101.Feb 1 2022, 09:12

Harbormaster completed remote builds in B18091: Diff 32102.Feb 1 2022, 09:20

Closed by commit rABC43a7ffb79d05: Remove m_is_manual_connection from CNodeState (authored by Antoine Riard <ariard@student.42.fr>, committed by PiRK). · Explain WhyFeb 1 2022, 12:13

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC43a7ffb79d05: Remove m_is_manual_connection from CNodeState.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

23 lines

Diff 32105

View Options

Remove m_is_manual_connection from CNodeStateClosedPublicActions