Page MenuHomePhabricator
Differential D10949

Set type for "nodes".
ClosedPublic
Actions

Authored by PiRK on Feb 1 2022, 13:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5c70b37ed4b2: Set type for "nodes".
Summary

I noticed that navigation in PyCharm/VS Code did not work for nodes variable. I think this is frustrating, especially for newcomers.

This will make python IDEs work better with the test framework.
Our code already switched to python 3.6 types hints for chain and setup_clean_chain, so the only change for these attributes is to remove Optional.

This is a backport of core#20954

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 1 2022, 13:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2022, 13:29
PiRK requested review of this revision.Feb 1 2022, 13:29
teamcity edited the summary of this revision. (Show Details)Feb 1 2022, 13:29
Harbormaster completed remote builds in B18094: Diff 32106.Feb 1 2022, 13:45
Fabien accepted this revision.Feb 1 2022, 14:38
This revision is now accepted and ready to land.Feb 1 2022, 14:38
Closed by commit rABC5c70b37ed4b2: Set type for "nodes". (authored by Kiminuo <kiminuo@protonmail.com>, committed by PiRK). · Explain WhyFeb 1 2022, 14:51
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5c70b37ed4b2: Set type for "nodes"..

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
11 lines

Diff 32114

View Options

test/functional/test_framework/test_framework.py

Loading...