Page MenuHomePhabricator

Set type for "nodes".
ClosedPublic

Authored by PiRK on Feb 1 2022, 13:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5c70b37ed4b2: Set type for "nodes".
Summary

I noticed that navigation in PyCharm/VS Code did not work for nodes variable. I think this is frustrating, especially for newcomers.

This will make python IDEs work better with the test framework.
Our code already switched to python 3.6 types hints for chain and setup_clean_chain, so the only change for these attributes is to remove Optional.

This is a backport of core#20954

Test Plan

ninja check-functional

Diff Detail

Event Timeline

PiRK requested review of this revision.Feb 1 2022, 13:29
This revision is now accepted and ready to land.Feb 1 2022, 14:38
This revision was automatically updated to reflect the committed changes.