net: make CNode::m_inbound_onion public, initialize explicitly
ClosedPublic
Actions

Authored by PiRK on Feb 3 2022, 12:11.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc7840f727ef6: net: make CNode::m_inbound_onion public, initialize explicitly

Summary

net: make CNode::m_inbound_onion public, drop getter, update tests

net: remove CNode::m_inbound_onion defaults for explicitness

and to allow the compiler to warn if uninitialized in the ctor
or omitted in the caller.

This is a backport of core#21167

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 3 2022, 12:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2022, 12:11

PiRK requested review of this revision.Feb 3 2022, 12:11

teamcity edited the summary of this revision. (Show Details)Feb 3 2022, 12:12

Harbormaster completed remote builds in B18131: Diff 32166.Feb 3 2022, 12:19

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[169/458] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/parse_name_tests.cpp.o
[170/458] Automatic MOC for target test_bitcoin-qt
[171/458] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/grasberg_tests.cpp.o
[172/458] Linking CXX executable src/pow/test/test-pow
[173/458] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o
[174/458] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/message_writer_tests.cpp.o
[175/458] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/write_name_tests.cpp.o
[176/458] pow: testing eda_tests
[177/458] Running utility command for check-pow-eda_tests
[178/458] pow: testing daa_tests
[179/458] Running utility command for check-pow-daa_tests
[180/458] Test Bitcoin utilities...
[181/458] pow: testing grasberg_tests
[182/458] Running utility command for check-pow-grasberg_tests
[183/458] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
[184/458] Linking CXX executable src/seeder/test/test-seeder
[185/458] seeder: testing write_name_tests
[186/458] Running utility command for check-seeder-write_name_tests
[187/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[188/458] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o
[189/458] seeder: testing options_tests
[190/458] Running utility command for check-seeder-options_tests
[191/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[192/458] seeder: testing message_writer_tests
[193/458] seeder: testing p2p_messaging_tests
[194/458] Running utility command for check-seeder-message_writer_tests
[195/458] Running utility command for check-seeder-p2p_messaging_tests
[196/458] seeder: testing parse_name_tests
[197/458] Running utility command for check-seeder-parse_name_tests
[198/458] Running seeder test suite
PASSED: seeder test suite
[199/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[200/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[201/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[202/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[203/458] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[204/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[205/458] pow: testing aserti32d_tests
[206/458] Running utility command for check-pow-aserti32d_tests
[207/458] Running pow test suite
PASSED: pow test suite
[208/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[209/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[210/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[211/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[212/458] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o
[213/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[214/458] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[215/458] Linking CXX executable src/qt/test/test_bitcoin-qt
[216/458] bitcoin-qt: testing test_bitcoin-qt
[217/458] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[218/458] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[166/453] Automatic MOC for target bitcoin-qt-base
[167/451] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/options_tests.cpp.o
[168/451] Automatic MOC for target test_bitcoin-qt
[169/451] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/scriptpubkeyman_tests.cpp.o
[170/451] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/parse_name_tests.cpp.o
[171/451] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/ismine_tests.cpp.o
[172/451] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o
[173/451] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
[174/451] Test Bitcoin utilities...
[175/451] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/write_name_tests.cpp.o
[176/451] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o
[177/451] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/message_writer_tests.cpp.o
[178/451] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o
[179/451] Linking CXX executable src/seeder/test/test-seeder
[180/451] seeder: testing write_name_tests
[181/451] Running utility command for check-seeder-write_name_tests
[182/451] seeder: testing options_tests
[183/451] Running utility command for check-seeder-options_tests
[184/451] seeder: testing message_writer_tests
[185/451] Running utility command for check-seeder-message_writer_tests
[186/451] seeder: testing p2p_messaging_tests
[187/451] Running utility command for check-seeder-p2p_messaging_tests
[188/451] seeder: testing parse_name_tests
[189/451] Running utility command for check-seeder-parse_name_tests
[190/451] Running seeder test suite
PASSED: seeder test suite
[191/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[192/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[193/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[194/451] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.005s

OK
[195/451] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.014s

OK
[196/451] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o
[197/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[198/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[199/451] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[200/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[201/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[202/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[203/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[204/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[205/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[206/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[207/451] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[208/451] Linking CXX executable src/qt/test/test_bitcoin-qt
[209/451] bitcoin-qt: testing test_bitcoin-qt
[210/451] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[211/451] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[0m[1;30mwallet_importprunedfunds.py --descriptors | ○ Skipped | 0 s
[0m[1;30mwallet_keypool.py                         | ○ Skipped | 0 s
[0m[1;30mwallet_keypool_topup.py                   | ○ Skipped | 0 s
[0m[1;30mwallet_keypool_topup.py --descriptors     | ○ Skipped | 0 s
[0m[1;30mwallet_labels.py                          | ○ Skipped | 0 s
[0m[1;30mwallet_labels.py --descriptors            | ○ Skipped | 0 s
[0m[1;30mwallet_listreceivedby.py                  | ○ Skipped | 0 s
[0m[1;30mwallet_listsinceblock.py                  | ○ Skipped | 0 s
[0m[1;30mwallet_listsinceblock.py --descriptors    | ○ Skipped | 0 s
[0m[1;30mwallet_listtransactions.py                | ○ Skipped | 0 s
[0m[1;30mwallet_listtransactions.py --descriptors  | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py                     | ○ Skipped | 0 s
[0m[1;30mwallet_multiwallet.py --usecli            | ○ Skipped | 0 s
[0m[1;30mwallet_reorgsrestore.py                   | ○ Skipped | 0 s
[0m[1;30mwallet_resendwallettransactions.py        | ○ Skipped | 0 s
[0m[1;30mwallet_send.py                            | ○ Skipped | 0 s
[0m[1;30mwallet_startup.py                         | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py                       | ○ Skipped | 0 s
[0m[1;30mwallet_txn_clone.py --mineblock           | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py                 | ○ Skipped | 0 s
[0m[1;30mwallet_txn_doublespend.py --mineblock     | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py                       | ○ Skipped | 0 s
[0m[1;30mwallet_watchonly.py --usecli              | ○ Skipped | 0 s
[0m[1m
ALL                                       | ✓ Passed  | 550 s (accumulated) 
[0mRuntime: 110 s

----------------------------------------------------------------------
Ran 10 tests in 0.162s

OK

[166/419] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[167/419] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[175/419] Running pow test suite
PASSED: pow test suite
[188/419] Running seeder test suite
PASSED: seeder test suite
[194/419] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[195/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:540:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[196/419] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[0m[0;32mwallet_import_with_label.py               | ✓ Passed  | 1 s
[0m[0;32mwallet_importdescriptors.py               | ✓ Passed  | 8 s
[0m[0;32mwallet_importmulti.py                     | ✓ Passed  | 6 s
[0m[0;32mwallet_importprunedfunds.py               | ✓ Passed  | 2 s
[0m[0;32mwallet_importprunedfunds.py --descriptors | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool.py                         | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                   | ✓ Passed  | 5 s
[0m[0;32mwallet_keypool_topup.py --descriptors     | ✓ Passed  | 4 s
[0m[0;32mwallet_labels.py                          | ✓ Passed  | 3 s
[0m[0;32mwallet_labels.py --descriptors            | ✓ Passed  | 2 s
[0m[0;32mwallet_listreceivedby.py                  | ✓ Passed  | 30 s
[0m[0;32mwallet_listsinceblock.py                  | ✓ Passed  | 7 s
[0m[0;32mwallet_listsinceblock.py --descriptors    | ✓ Passed  | 10 s
[0m[0;32mwallet_listtransactions.py                | ✓ Passed  | 5 s
[0m[0;32mwallet_listtransactions.py --descriptors  | ✓ Passed  | 4 s
[0m[0;32mwallet_multiwallet.py                     | ✓ Passed  | 54 s
[0m[0;32mwallet_multiwallet.py --usecli            | ✓ Passed  | 17 s
[0m[0;32mwallet_reorgsrestore.py                   | ✓ Passed  | 5 s
[0m[0;32mwallet_resendwallettransactions.py        | ✓ Passed  | 4 s
[0m[0;32mwallet_send.py                            | ✓ Passed  | 7 s
[0m[0;32mwallet_startup.py                         | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_clone.py                       | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_clone.py --mineblock           | ✓ Passed  | 4 s
[0m[0;32mwallet_txn_doublespend.py                 | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py --mineblock     | ✓ Passed  | 4 s
[0m[0;32mwallet_watchonly.py                       | ✓ Passed  | 2 s
[0m[0;32mwallet_watchonly.py --usecli              | ✓ Passed  | 2 s
[0m[1m
ALL                                       | ✓ Passed  | 1577 s (accumulated) 
[0mRuntime: 316 s

----------------------------------------------------------------------
Ran 10 tests in 0.155s

OK

[162/459] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.005s

OK
[166/459] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[196/459] Running seeder test suite
PASSED: seeder test suite
[202/459] Running avalanche test suite
PASSED: avalanche test suite
[212/459] Running pow test suite
PASSED: pow test suite
[216/459] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[218/459] Running secp256k1 test suite
PASSED: secp256k1 test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mwallet_abandonconflict.py                 | ✓ Passed  | 13 s
[0m[0;32mwallet_address_types.py                   | ✓ Passed  | 12 s
[0m[0;32mwallet_address_types.py --descriptors     | ✓ Passed  | 9 s
[0m[0;32mwallet_avoidreuse.py                      | ✓ Passed  | 5 s
[0m[0;32mwallet_avoidreuse.py --descriptors        | ✓ Passed  | 4 s
[0m[0;32mwallet_backup.py                          | ✓ Passed  | 27 s
[0m[0;32mwallet_balance.py                         | ✓ Passed  | 9 s
[0m[0;32mwallet_balance.py --descriptors           | ✓ Passed  | 7 s
[0m[0;32mwallet_basic.py                           | ✓ Passed  | 22 s
[0m[0;32mwallet_coinbase_category.py               | ✓ Passed  | 1 s
[0m[0;32mwallet_create_tx.py                       | ✓ Passed  | 5 s
[0m[0;32mwallet_createwallet.py                    | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --descriptors      | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --usecli           | ✓ Passed  | 3 s
[0m[0;32mwallet_descriptor.py                      | ✓ Passed  | 8 s
[0m[0;32mwallet_disable.py                         | ✓ Passed  | 1 s
[0m[0;32mwallet_dump.py                            | ✓ Passed  | 4 s
[0m[0;32mwallet_encryption.py                      | ✓ Passed  | 5 s
[0m[0;32mwallet_encryption.py --descriptors        | ✓ Passed  | 5 s
[0m[0;32mwallet_hd.py                              | ✓ Passed  | 6 s
[0m[0;32mwallet_hd.py --descriptors                | ✓ Passed  | 5 s
[0m[0;32mwallet_import_rescan.py                   | ✓ Passed  | 5 s
[0m[0;32mwallet_import_with_label.py               | ✓ Passed  | 1 s
[0m[0;32mwallet_importdescriptors.py               | ✓ Passed  | 6 s
[0m[0;32mwallet_importmulti.py                     | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py               | ✓ Passed  | 2 s
[0m[0;32mwallet_importprunedfunds.py --descriptors | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                         | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py --descriptors     | ✓ Passed  | 3 s
[0m[0;32mwallet_labels.py                          | ✓ Passed  | 2 s
[0m[0;32mwallet_labels.py --descriptors            | ✓ Passed  | 2 s
[0m[0;32mwallet_listreceivedby.py                  | ✓ Passed  | 13 s
[0m[0;32mwallet_listsinceblock.py                  | ✓ Passed  | 5 s
[0m[0;32mwallet_listsinceblock.py --descriptors    | ✓ Passed  | 10 s
[0m[0;32mwallet_listtransactions.py                | ✓ Passed  | 4 s
[0m[0;32mwallet_listtransactions.py --descriptors  | ✓ Passed  | 3 s
[0m[0;32mwallet_multiwallet.py                     | ✓ Passed  | 40 s
[0m[0;32mwallet_multiwallet.py --usecli            | ✓ Passed  | 10 s
[0m[0;32mwallet_reorgsrestore.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py        | ✓ Passed  | 12 s
[0m[0;32mwallet_send.py                            | ✓ Passed  | 8 s
[0m[0;32mwallet_startup.py                         | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py                       | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_clone.py --mineblock           | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py                 | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_doublespend.py --mineblock     | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                       | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli              | ✓ Passed  | 1 s
[0m[1m
ALL                                       | ✓ Passed  | 1123 s (accumulated) 
[0mRuntime: 225 s

----------------------------------------------------------------------
Ran 10 tests in 0.093s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

PiRK planned changes to this revision.Feb 3 2022, 12:49

Fix one more CNode.

Harbormaster completed remote builds in B18132: Diff 32167.Feb 3 2022, 13:06

PiRK added a child revision: D10975: Extract ProtectEvictionCandidatesByRatio from SelectNodeToEvict.Feb 3 2022, 15:13

Fabien accepted this revision.Feb 3 2022, 16:44

This revision is now accepted and ready to land.Feb 3 2022, 16:44

Closed by commit rABCc7840f727ef6: net: make CNode::m_inbound_onion public, initialize explicitly (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyFeb 4 2022, 08:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc7840f727ef6: net: make CNode::m_inbound_onion public, initialize explicitly.

PiRK mentioned this in D10983: fix CNode construction in denialofservice_tests.cpp.Feb 4 2022, 09:23

PiRK mentioned this in rABC8adea148613a: fix CNode construction in denialofservice_tests.cpp.Feb 4 2022, 09:32

Fabien mentioned this in D10989: Fix CNode construction in fuzz tests.Feb 4 2022, 10:52