Differential D10977

Use std::unordered_set instead of std::vector in IsEvicted()
ClosedPublic
Actions

Authored by PiRK on Feb 3 2022, 15:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC7128106e3b4c: Use std::unordered_set instead of std::vector in IsEvicted()

Summary

An unordered set can tell if an element is present in ~O(1) time (constant on
average, worst case linear to the size of the container), which speeds up and
simplifies the lookup in IsEvicted().

Co-authored-by: Vasil Dimov <vd@FreeBSD.org>

This is a backport of core#20197 [3/6]
https://github.com/bitcoin/bitcoin/pull/20197/commits/ca63b53ecdf377ce777fd959d400748912266748
Depends on D10976

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 3 2022, 15:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2022, 15:17

PiRK requested review of this revision.Feb 3 2022, 15:17

teamcity edited the summary of this revision. (Show Details)Feb 3 2022, 15:17

PiRK added a child revision: D10978: Add unit tests for ProtectEvictionCandidatesByRatio().Feb 3 2022, 15:19

Harbormaster completed remote builds in B18136: Diff 32172.Feb 3 2022, 15:39

Fabien accepted this revision.Feb 4 2022, 09:00

This revision is now accepted and ready to land.Feb 4 2022, 09:00

Closed by commit rABC7128106e3b4c: Use std::unordered_set instead of std::vector in IsEvicted() (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyFeb 4 2022, 11:00

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7128106e3b4c: Use std::unordered_set instead of std::vector in IsEvicted().

Revision Contents
Changeset List

Path

Size

src/

test/

net_peer_eviction_tests.cpp

12 lines

Diff 32200

View Options

src/test/net_peer_eviction_tests.cpp

Use std::unordered_set instead of std::vector in IsEvicted()ClosedPublicActions