Page MenuHomePhabricator
Differential D10988

refactor: Drop boost::thread stuff in CCheckQueue
ClosedPublic
Actions

Authored by PiRK on Feb 4 2022, 10:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe376425680c8: refactor: Drop boost::thread stuff in CCheckQueue
Summary

This is a backport of core#18710 [4/4]
https://github.com/bitcoin/bitcoin/pull/18710/commits/bb6fcc75d1ec94b733d1477c816351c50be5faf9

Depends on D10987

Test Plan

With TSAN: ninja && ninja check check-functional

cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 4 2022, 10:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2022, 10:47
PiRK requested review of this revision.Feb 4 2022, 10:47
teamcity edited the summary of this revision. (Show Details)Feb 4 2022, 10:49
Harbormaster completed remote builds in B18154: Diff 32196.Feb 4 2022, 11:53
Fabien requested changes to this revision.Feb 4 2022, 13:13
Fabien added a subscriber: Fabien.

Please add a Clang (for annotations) and Debug (for lock order consistency) runs to the test plan.

This revision now requires changes to proceed.Feb 4 2022, 13:13
PiRK updated this revision to Diff 32208.Feb 4 2022, 13:27
PiRK edited the test plan for this revision. (Show Details)

add clang and debug runs to test plan

Fabien accepted this revision.Feb 4 2022, 13:39
This revision is now accepted and ready to land.Feb 4 2022, 13:39
Harbormaster completed remote builds in B18158: Diff 32208.Feb 4 2022, 13:59
Closed by commit rABCe376425680c8: refactor: Drop boost::thread stuff in CCheckQueue (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyFeb 4 2022, 13:59
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCe376425680c8: refactor: Drop boost::thread stuff in CCheckQueue.

Revision Contents
Changeset List

PathSize
src/
57 lines
test/
4 lines
test/
lint/
1 line

Diff 32213

View Options

src/checkqueue.h

Loading...
View Options

src/test/checkqueue_tests.cpp

Loading...
View Options

test/lint/lint-boost-dependencies.sh

Loading...