Page MenuHomePhabricator
Differential D10986

Add local thread pool to CCheckQueue and use it in tests
ClosedPublic
Actions

Authored by PiRK on Feb 4 2022, 10:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8b2338aa8717: Add local thread pool to CCheckQueue and use it in tests
Summary

This is a backport of [[https://github.com/bitcoin/bitcoin/pull/18710 | core#18710]] [2/4]
https://github.com/bitcoin/bitcoin/pull/18710/commits/01511776acb0c7ec216dc9c8112531067763f1cb
https://github.com/bitcoin/bitcoin/pull/18710/commits/dba30695fc42f45828db008e7e5b81cb2b5d8551

Depends on D10985

Test Plan

With TSAN:
ninja && ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 4 2022, 10:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2022, 10:44
PiRK requested review of this revision.Feb 4 2022, 10:44
teamcity edited the summary of this revision. (Show Details)Feb 4 2022, 10:45
PiRK added a child revision: D10987: bench: Use CCheckQueue local thread pool.Feb 4 2022, 10:46
teamcity edited the summary of this revision. (Show Details)Feb 4 2022, 10:50
Harbormaster completed remote builds in B18152: Diff 32194.Feb 4 2022, 11:13
Fabien requested changes to this revision.Feb 4 2022, 13:07
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.h
243 ↗(On Diff #32194)

Remove

This revision now requires changes to proceed.Feb 4 2022, 13:07
PiRK updated this revision to Diff 32207.Feb 4 2022, 13:22
PiRK edited the test plan for this revision. (Show Details)

remove unused ThreadScriptCheck from validation.h

Fabien accepted this revision.Feb 4 2022, 13:38
This revision is now accepted and ready to land.Feb 4 2022, 13:38
Harbormaster completed remote builds in B18157: Diff 32207.Feb 4 2022, 13:50
Closed by commit rABC8b2338aa8717: Add local thread pool to CCheckQueue and use it in tests (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyFeb 4 2022, 13:59
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC8b2338aa8717: Add local thread pool to CCheckQueue and use it in tests.
PiRK mentioned this in D10994: Add include for std::bind..Feb 4 2022, 16:47
PiRK mentioned this in rABCcc38d7188d5a: Add include for std::bind..Feb 7 2022, 14:12

Revision Contents
Changeset List

PathSize
src/
51 lines
5 lines
test/
49 lines
10 lines
util/
5 lines
9 lines
9 lines

Diff 32211

View Options

src/checkqueue.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/test/checkqueue_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...