Page MenuHomePhabricator
Differential D11038

[Cashtab] Add support for Swiss Franc
ClosedPublic
Actions

Authored by kieran709 on Feb 10 2022, 18:34.

Details

Reviewers
bytesofman
emack
Group Reviewers
Restricted Project
Commits
rABC5921ce974862: [Cashtab] Add support for Swiss Franc
Summary

Added support for Swiss Franc (CHF). One issue is, if using the internationally accepted "CHF" for the symbol, the amount appears as "CHF [amount] CHF". According to some sources, Fr. is an acceptable currency symbol, which displays the amount as "Fr. [amount] CHF" which I think is easier on the eyes. That said, it can be changed back if that is preferrable. Related to task T2210.

Test Plan

cd web/cashtab && npm start
navigate to settings tab
select Swiss Franc from dropdown menu
navigate to wallet tab and check that CHF is the selected currency
using an online conversion tool, ensure conversion is taking place

Diff Detail

Repository
rABC Bitcoin ABC
Branch
support-swiss-franc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18245
Build 36298: Build Diffcashtab-tests
Build 36297: arc lint + arc unit

Event Timeline

kieran709 created this revision.Feb 10 2022, 18:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2022, 18:34
kieran709 requested review of this revision.Feb 10 2022, 18:34
Harbormaster completed remote builds in B18245: Diff 32338.Feb 10 2022, 18:38
kieran709 edited the summary of this revision. (Show Details)Feb 11 2022, 00:02
bytesofman requested changes to this revision.Feb 11 2022, 19:40
bytesofman added inline comments.
web/cashtab/src/components/Common/Ticker.js
79

Make sure to follow current convention of alphabetical order by name:, not key

This revision now requires changes to proceed.Feb 11 2022, 19:40
kieran709 updated this revision to Diff 32355.Feb 11 2022, 22:05

Responding to review feedback.

Harbormaster completed remote builds in B18257: Diff 32355.Feb 11 2022, 22:08
bytesofman accepted this revision.Feb 12 2022, 00:07
This revision is now accepted and ready to land.Feb 12 2022, 00:07
Closed by commit rABC5921ce974862: [Cashtab] Add support for Swiss Franc (authored by kieran709). · Explain WhyFeb 14 2022, 16:13
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC5921ce974862: [Cashtab] Add support for Swiss Franc.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Common/
2 lines

Diff 32338

View Options

web/cashtab/src/components/Common/Ticker.js

Loading...