Page MenuHomePhabricator
Differential D11072

Simplify the abc_mining_basic.py test
ClosedPublic
Actions

Authored by Fabien on Feb 18 2022, 14:46.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCc76611d6843a: Simplify the abc_mining_basic.py test
Summary

The test uses getblocktemplate which checks that the node is connected to at least one peer. Rather than spinning a node, just use the test framework to work around this check.

Test Plan
./test/functional/test_runner.py abc_mining_basic

Diff Detail

Repository
rABC Bitcoin ABC
Branch
abc_mining_basic_p2pinterface
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18301
Build 36407: Build Diffbuild-clang-tidy · build-diff · build-without-wallet · build-debug · build-clang
Build 36406: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 18 2022, 14:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 18 2022, 14:46
Fabien requested review of this revision.Feb 18 2022, 14:46
Harbormaster completed remote builds in B18301: Diff 32434.Feb 18 2022, 15:01
Fabien added a child revision: Restricted Differential Revision.Feb 18 2022, 15:27
PiRK accepted this revision.Feb 21 2022, 07:13
This revision is now accepted and ready to land.Feb 21 2022, 07:13
Closed by commit rABCc76611d6843a: Simplify the abc_mining_basic.py test (authored by Fabien). · Explain WhyFeb 21 2022, 08:43
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCc76611d6843a: Simplify the abc_mining_basic.py test.

Revision Contents
Changeset List

PathSize
test/
functional/
41 lines

Diff 32434

View Options

test/functional/abc_mining_basic.py

Loading...