Page MenuHomePhabricator
Differential D11078

util: add ParseUInt16(), use it in SplitHostPort()
ClosedPublic
Actions

Authored by PiRK on Feb 18 2022, 17:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc38178957acb: util: add ParseUInt16(), use it in SplitHostPort()
Summary

This is a backport of core#21328 [2/3] and core#21488 (unit tests)
https://github.com/bitcoin/bitcoin/pull/21328/commits/2875a764f7d8b1503c7bdb2f262964f7a0cb5fc3

Depends on D11077 and D11081

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 18 2022, 17:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 18 2022, 17:00
PiRK requested review of this revision.Feb 18 2022, 17:00
teamcity edited the summary of this revision. (Show Details)Feb 18 2022, 17:01
PiRK added a child revision: D11079: test: add missing netaddress include headers.Feb 18 2022, 17:03
Harbormaster completed remote builds in B18308: Diff 32441.Feb 18 2022, 17:18
Fabien requested changes to this revision.Feb 18 2022, 18:05
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/util/strencodings.cpp
364 ↗(On Diff #32441)

This is missing a unit test

This revision now requires changes to proceed.Feb 18 2022, 18:05
PiRK updated this revision to Diff 32446.Feb 21 2022, 07:07
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D11081: test: add ParseUInt8() unit and fuzz test coverage.

squash with core#21488

PiRK edited the test plan for this revision. (Show Details)Feb 21 2022, 07:08
Harbormaster completed remote builds in B18313: Diff 32446.Feb 21 2022, 07:31
Fabien added inline comments.Feb 21 2022, 08:58
src/test/util_tests.cpp
1769 ↗(On Diff #32446)

This line is duplicated ? Looks like the case also in the PR, can you check if this was fixed ?

Fabien mentioned this in D11081: test: add ParseUInt8() unit and fuzz test coverage.Feb 21 2022, 09:00
PiRK updated this revision to Diff 32451.Feb 21 2022, 09:12

de-duplicate assertion

PiRK added a child revision: D11082: test: remove duplicate assertions in util_tests.Feb 21 2022, 09:13
Fabien accepted this revision.Feb 21 2022, 09:19
This revision is now accepted and ready to land.Feb 21 2022, 09:19
Harbormaster completed remote builds in B18315: Diff 32451.Feb 21 2022, 09:50
Closed by commit rABCc38178957acb: util: add ParseUInt16(), use it in SplitHostPort() (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyFeb 21 2022, 13:23
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCc38178957acb: util: add ParseUInt16(), use it in SplitHostPort().

Revision Contents
Changeset List

PathSize
src/
test/
fuzz/
3 lines
34 lines
util/
9 lines
15 lines

Diff 32461

View Options

src/test/fuzz/parse_numbers.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...