Paths

Table of Contentst

Differential D11081

test: add ParseUInt8() unit and fuzz test coverage
ClosedPublic
Actions

Authored by PiRK on Feb 21 2022, 07:04.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1d2c8c42a346: test: add ParseUInt8() unit and fuzz test coverage

Summary

Also reuse test string with embedded null char in other tests.

This is a backport of core#21438

Test Plan

ninja check bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Feb 21 2022, 07:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 21 2022, 07:04

PiRK requested review of this revision.Feb 21 2022, 07:04

teamcity edited the summary of this revision. (Show Details)Feb 21 2022, 07:05

PiRK edited the summary of this revision. (Show Details)Feb 21 2022, 07:06

PiRK added a child revision: D11078: util: add ParseUInt16(), use it in SplitHostPort().Feb 21 2022, 07:07

Harbormaster completed remote builds in B18312: Diff 32445.Feb 21 2022, 07:31

Fabien added a subscriber: Fabien.Feb 21 2022, 09:00

Fabien added inline comments.

src/test/util_tests.cpp
1734 ↗	(On Diff #32445)	See comment in D11078

de-duplicate assertion

PiRK added a child revision: D11082: test: remove duplicate assertions in util_tests.Feb 21 2022, 09:13

Fabien requested changes to this revision.Feb 21 2022, 09:22

Fabien added inline comments.

src/test/util_tests.cpp
1730 ↗	(On Diff #32450)	You dedup'ed the wrong one
1734 ↗	(On Diff #32450)	You wanted this one

This revision now requires changes to proceed.Feb 21 2022, 09:22

Harbormaster completed remote builds in B18314: Diff 32450.Feb 21 2022, 09:43

undeduplicate the line in test_ParseInt32 and deduplicate the line related to this pr in test_parseUInt8

PiRK mentioned this in D11082: test: remove duplicate assertions in util_tests.Feb 21 2022, 10:39

Harbormaster completed remote builds in B18318: Diff 32454.Feb 21 2022, 10:52

Fabien accepted this revision.Feb 21 2022, 12:45

This revision is now accepted and ready to land.Feb 21 2022, 12:45

Closed by commit rABC1d2c8c42a346: test: add ParseUInt8() unit and fuzz test coverage (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyFeb 21 2022, 13:23

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1d2c8c42a346: test: add ParseUInt8() unit and fuzz test coverage.

Revision Contents
Changeset List

Path

Size

src/

test/

fuzz/

parse_numbers.cpp

3 lines

util_tests.cpp

61 lines

Diff 32460

View Options

src/test/fuzz/parse_numbers.cpp