Page MenuHomePhabricator

scripted-diff: Rename touched CNode member variables
ClosedPublic

Authored by PiRK on Feb 21 2022, 13:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC73c309dc2407: scripted-diff: Rename touched CNode member variables
Summary
-BEGIN VERIFY SCRIPT-

 ren() { sed -i "s/\<$1\>/$2/g" $( git grep -l "$1" ./src/ ) ; }

 ren nLastBlockTime m_last_block_time
 ren nLastTXTime    m_last_tx_time
 ren nTimeConnected m_connected
 ren nLastProofTime m_last_proof_time

-END VERIFY SCRIPT-

This is a backport of core#23758 [3/3]
https://github.com/bitcoin/bitcoin/pull/23758/commits/fad943821e35d0eb2143061e718f0193e12a4c71

Depends on D11085

Test Plan

ninja all check-all bitcoin-bench bitcoin-fuzzers && src/bench/bitcoin-bench

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Feb 21 2022, 13:56

How does this build without the change the the peer_eviction benchmark ?

PiRK planned changes to this revision.Feb 21 2022, 16:13

How does this build without the change the the peer_eviction benchmark ?

I foobared D11084 in a way that removed these variables from peer_eviction.cpp. Will fix.

PiRK edited the test plan for this revision. (Show Details)

Rebase after fixing D11084 and include the changes in bench/peer_eviction.cpp

This revision is now accepted and ready to land.Feb 21 2022, 16:30
This revision was landed with ongoing or failed builds.Feb 21 2022, 16:38
This revision was automatically updated to reflect the committed changes.