Tapping a tx in tx history extends a collapse which reveals: a link to the tx that opens the block explorer in a new tab and a copy txid button which fires a notification when the txid has been copied to the user's clipboard. Related to task T1774.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC2524ad02e1b8: [Cashtab] Tx History collapse menu
cd web/cashtab
npm start
on the main wallet tab, click on a transaction
onClick, the tx card should expand, revealing a link to the tx on the block explorer>
click on the link, it should open the block explorer in a new tab
click on the Copy Txid button, it should fire a success notification
paste the txid somewhere to ensure it was copied to the clipboard.
send XEC, check that the new transaction panel expands on click
receive XEC, check that the new transaction panel expands on click
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- tx-history-collapse
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 18392 Build 36581: Build Diff cashtab-tests Build 36580: arc lint + arc unit
Event Timeline
| web/cashtab/src/components/Home/Tx.js | ||
|---|---|---|
| 673 ↗ | (On Diff #32538) | Create these icons with their required css in the CustomIcons.js file under components/common. Then export them here. |
| 688 ↗ | (On Diff #32538) | Create these icons with their required css in the CustomIcons.js file under components/common. Then export them here. |
Comment Actions
The antd down arrow is still visible -- please remove (without removing it from other Collapse items)
| web/cashtab/src/components/Home/Tx.js | ||
|---|---|---|
| 661 | we use react-copy-to-clipboard for copying addresses on the Receive screen -- why not here? If this approach is preferable (getting rid of a dependency is in general always a good option, so this is likely better), then we should create a task to migrate away from react-copy-to-clipboard. Please
| |
| 678 | use the param in currency object from Ticker.js, do not hardcode blockexplorer link | |
Comment Actions
Having looked into it further, I think it will be better to use react-copy-to-clipboard throughout the app as the navigator.clipboard.writeText() method will not work consistently across all browsers. This change will be reflected in my incoming revision.
Comment Actions
Replaced navigator copy to clipboard method with react-copy-to-clipboard. Removed hardcoded explorer url and replaced it with param in currency object.
Comment Actions
one nit, see inline
| web/cashtab/src/components/Common/StyledCollapse.js | ||
|---|---|---|
| 107 ↗ | (On Diff #32595) | Delete this commented out css |