Fixed casting issue in coins_tests.cpp for older versions of gcc (~5.4.0)
ClosedPublic
Actions

Authored by jasonbcox on Feb 19 2018, 18:11.

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING6617867d1b7e: Fixed casting issue in coins_tests.cpp for older versions of gcc (~5.4.0)
rABC6617867d1b7e: Fixed casting issue in coins_tests.cpp for older versions of gcc (~5.4.0)

Summary

Discovered this issue when attempting to compile using gcc 5.4.0 on Ubuntu 16.04. This issue doesn't appear to exist in newer versions of gcc (7.2.0).

Test Plan

Both cmake -GNinja .. && ninja and make check succeed.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

gcc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1891
Build 1942: Bitcoin ABC Buildbot (legacy)
Build 1941: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 19 2018, 18:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 19 2018, 18:11

schancel accepted this revision.Feb 19 2018, 18:13

This revision is now accepted and ready to land.Feb 19 2018, 18:13

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1891: Diff 2926.Feb 19 2018, 18:35

Closed by commit rABC6617867d1b7e: Fixed casting issue in coins_tests.cpp for older versions of gcc (~5.4.0) (authored by jasonbcox). · Explain WhyFeb 19 2018, 18:36

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

coins_tests.cpp

3 lines

Diff 2926

View Options

Fixed casting issue in coins_tests.cpp for older versions of gcc (~5.4.0)ClosedPublicActions