Page MenuHomePhabricator

[Cashtab] Remove unused styled import from TokenIcon.js
ClosedPublic

Authored by kieran709 on Mar 14 2022, 14:41.

Details

Summary

Removed unused styled-components import from TokenIcon.js Related to task T2297.

Test Plan

Navigate to /web/cashtab/components/Tokens/TokenIcon.js and ensure styled-components import is removed.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-unused-import-token-icon
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18482
Build 36759: Build Diffcashtab-tests
Build 36758: arc lint + arc unit

Event Timeline

Failed tests logs:

====== CashTab Unit Tests: useBCH hook sends XEC throws error attempting to encrypt a message with an invalid address ======
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  - 2
+ Received  + 2

  Object {
-   "error": "Unsupported address format : INVALIDADDRESS",
-   "success": false,
+   "message": "Not Found",
+   "status": 404,
  }
    at Object.<anonymous> (/work/web/cashtab/src/hooks/__tests__/useBCH.test.js:222:29)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: useBCH hook sends XEC throws error attempting to encrypt a message with an invalid address

added comment to force new test.

Tail of the build log:

/work/web/cashtab /work/abc-ci-builds/cashtab-tests
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'eslint-plugin-jest@25.3.4',
npm WARN EBADENGINE   required: { node: '^12.13.0 || ^14.15.0 || >=16.0.0' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@typescript-eslint/experimental-utils@5.9.0',
npm WARN EBADENGINE   required: { node: '^12.22.0 || ^14.17.0 || >=16.0.0' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@typescript-eslint/scope-manager@5.9.0',
npm WARN EBADENGINE   required: { node: '^12.22.0 || ^14.17.0 || >=16.0.0' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@typescript-eslint/types@5.9.0',
npm WARN EBADENGINE   required: { node: '^12.22.0 || ^14.17.0 || >=16.0.0' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@typescript-eslint/typescript-estree@5.9.0',
npm WARN EBADENGINE   required: { node: '^12.22.0 || ^14.17.0 || >=16.0.0' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@typescript-eslint/visitor-keys@5.9.0',
npm WARN EBADENGINE   required: { node: '^12.22.0 || ^14.17.0 || >=16.0.0' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'eslint-visitor-keys@3.1.0',
npm WARN EBADENGINE   required: { node: '^12.22.0 || ^14.17.0 || >=16.0.0' },
npm WARN EBADENGINE   current: { node: 'v15.14.0', npm: '7.7.6' }
npm WARN EBADENGINE }
npm notice 
npm notice New major version of npm available! 7.7.6 -> 8.5.4
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.4>
npm notice Run `npm install -g npm@8.5.4` to update!
npm notice 
npm ERR! code ERR_SOCKET_TIMEOUT
npm ERR! errno ERR_SOCKET_TIMEOUT
npm ERR! request to https://registry.npmjs.org/@babel%2fplugin-transform-runtime failed, reason: Socket timeout

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-03-14T20_50_19_542Z-debug.log
Build cashtab-tests failed with exit code 1
This revision is now accepted and ready to land.Mar 14 2022, 22:00