Page MenuHomePhabricator
Differential D11173

validation: Move global LookupBlockIndex method to BlockManager
ClosedPublic
Actions

Authored by PiRK on Mar 15 2022, 14:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC292bd9871868: validation: Move global LookupBlockIndex method to BlockManager
Summary

LookupBlockIndex only acts on BlockManager.

This is a backport of core#20749 [2, 3 & 4/17]
https://github.com/bitcoin/bitcoin/pull/20749/commits/15d20f40e1321b24963b40c12958c7d30ad112ec
https://github.com/bitcoin/bitcoin/pull/20749/commits/eae54e6e60d7ed05b29d8345c0bb055397149ce8
https://github.com/bitcoin/bitcoin/pull/20749/commits/3664a150ac7547c9336b571557af223d9e31aac9

Depends on D11172

Test Plan

With debug:
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 15 2022, 14:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 15 2022, 14:56
PiRK requested review of this revision.Mar 15 2022, 14:56
teamcity edited the summary of this revision. (Show Details)Mar 15 2022, 14:57
PiRK edited the summary of this revision. (Show Details)Mar 15 2022, 14:58
PiRK added a parent revision: D11172: validation: Guard the active_chainstate with cs_main.
Harbormaster completed remote builds in B18492: Diff 32716.Mar 15 2022, 15:18
PiRK added a child revision: D11174: validation: Move FindForkInGlobalIndex to BlockManager.Mar 15 2022, 15:37
Fabien accepted this revision.Mar 15 2022, 17:27
This revision is now accepted and ready to land.Mar 15 2022, 17:27
Closed by commit rABC292bd9871868: validation: Move global LookupBlockIndex method to BlockManager (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 16 2022, 09:12
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC292bd9871868: validation: Move global LookupBlockIndex method to BlockManager.
roqqit mentioned this in D16383: [avalanche] Cleanup include in processor_tests.Wed, Jun 26, 19:14
roqqit mentioned this in rABCf8c89801a7d4: [avalanche] Cleanup include in processor_tests.Wed, Jun 26, 19:43

Revision Contents
Changeset List

PathSize
src/
avalanche/
6 lines
test/
12 lines
2 lines
index/
3 lines
6 lines
interfaces/
28 lines
35 lines
node/
3 lines
5 lines
rpc/
31 lines
11 lines
12 lines
test/
15 lines
6 lines
6 lines
22 lines

Diff 32732

View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/checkpoints.cpp

Loading...
View Options

src/index/base.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/node/coinstats.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/test/blockfilter_index_tests.cpp

Loading...
View Options

src/test/checkpoints_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...