Page MenuHomePhabricator
Differential D11191

validation: Pass in chain tip to ::ContextualCheckTransactionForCurrentBlock
ClosedPublic
Actions

Authored by PiRK on Mar 16 2022, 14:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC98315e93d51a: validation: Pass in chain tip to ::ContextualCheckTransactionForCurrentBlock
Summary

This is a backport of core#20750 [3, 4 & 5/19]
https://github.com/bitcoin/bitcoin/pull/20750/commits/d015eaa550027a387cd548cf0bcfa1a4c31a3374

https://github.com/bitcoin/bitcoin/pull/20750/commits/7031cf89db943d3e73597d2f9fa4a41908558e6c

https://github.com/bitcoin/bitcoin/pull/20750/commits/577b774d0c664b891bc9e1550ef179a655a466ad

Depends on D11190

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 16 2022, 14:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 16 2022, 14:57
PiRK requested review of this revision.Mar 16 2022, 14:57
teamcity edited the summary of this revision. (Show Details)Mar 16 2022, 14:58
PiRK planned changes to this revision.Mar 16 2022, 15:05
Harbormaster completed remote builds in B18514: Diff 32757.Mar 16 2022, 15:07
teamcity added a comment.Mar 16 2022, 15:07
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[345/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[346/517] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[347/517] Linking C static library src/secp256k1/libsecp256k1.a
[348/517] Linking CXX static library src/libbitcoinconsensus.a
[349/517] Linking C executable src/secp256k1/ecmult-bench
[350/517] Linking C executable src/secp256k1/internal-bench
[351/517] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[352/517] Linking C executable src/secp256k1/sign-bench
[353/517] Linking CXX static library src/libscript.a
[354/517] Linking C executable src/secp256k1/verify-bench
[355/517] Linking C executable src/secp256k1/recover-bench
[356/517] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[357/517] Linking CXX static library src/libcommon.a
[358/517] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[359/517] Linking CXX shared library src/libbitcoinconsensus.so.0.25.2
[360/517] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[361/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[362/517] Linking CXX executable src/bitcoin-cli
[363/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[364/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[365/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[366/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[367/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[368/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[369/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[370/517] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[371/517] Linking CXX executable src/bitcoin-tx
[372/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[373/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[374/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[375/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[376/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[377/517] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[378/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[379/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[380/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[381/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[382/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[383/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[384/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[385/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[386/517] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[387/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[388/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[389/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[390/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[391/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[392/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[393/517] Linking CXX static library src/wallet/libwallet.a
[394/517] Linking CXX static library src/wallet/libwallet-tool.a
[395/517] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Mar 16 2022, 15:09
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[337/515] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[338/515] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[339/515] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[340/515] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[341/515] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[342/515] Linking C static library src/secp256k1/libsecp256k1.a
[343/515] Linking C executable src/secp256k1/ecmult-bench
[344/515] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[345/515] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[346/515] Linking C executable src/secp256k1/sign-bench
[347/515] Linking C executable src/secp256k1/verify-bench
[348/515] Linking C executable src/secp256k1/recover-bench
[349/515] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[350/515] Linking CXX static library src/libbitcoinconsensus.a
[351/515] Linking CXX static library src/libscript.a
[352/515] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[353/515] Linking CXX static library src/libcommon.a
[354/515] Linking CXX shared library src/libbitcoinconsensus.so.0.25.2
[355/515] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[356/515] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[357/515] Linking CXX executable src/bitcoin-cli
[358/515] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[359/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[360/515] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[361/515] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[362/515] Linking C executable src/secp256k1/internal-bench
[363/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[364/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[365/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[366/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[367/515] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[368/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[369/515] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[370/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[371/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[372/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[373/515] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[374/515] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[375/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[376/515] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[377/515] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[378/515] Linking CXX executable src/bitcoin-tx
[379/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[380/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[381/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[382/515] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[383/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[384/515] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[385/515] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[386/515] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[387/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[388/515] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[389/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[390/515] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[391/515] Linking CXX static library src/wallet/libwallet.a
[392/515] Linking CXX static library src/wallet/libwallet-tool.a
[393/515] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[394/515] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Mar 16 2022, 15:09
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[348/517] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[349/517] Linking CXX static library src/libcommon.a
[350/517] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[351/517] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[352/517] Linking CXX shared library src/libbitcoinconsensus.so.0.25.2
[353/517] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[354/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[355/517] Linking CXX executable src/bitcoin-cli
[356/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[357/517] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[358/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[359/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[360/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[361/517] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[362/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[363/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[364/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[365/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[366/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[367/517] Linking CXX executable src/bitcoin-tx
[368/517] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp: In member function ‘bool {anonymous}::MemPoolAccept::PreChecks({anonymous}::MemPoolAccept::ATMPArgs&, {anonymous}::MemPoolAccept::Workspace&)’:
../../src/validation.cpp:472:56: error: cannot convert ‘const Consensus::Params’ to ‘const CBlockIndex*’
             args.m_config.GetChainParams().GetConsensus(), tx, ctxState,
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
In file included from ../../src/validation.cpp:7:
../../src/./validation.h:522:24: note:   initializing argument 1 of ‘bool ContextualCheckTransactionForCurrentBlock(const CBlockIndex*, const Consensus::Params&, const CTransaction&, TxValidationState&, int)’
     const CBlockIndex *active_chain_tip, const Consensus::Params &params,
     ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
[369/517] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[370/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[371/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[372/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[373/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[374/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[375/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[376/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[377/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[378/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[379/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[380/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[381/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[382/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[383/517] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[384/517] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[385/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[386/517] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[387/517] Linking CXX static library src/wallet/libwallet.a
[388/517] Linking CXX static library src/wallet/libwallet-tool.a
[389/517] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[390/517] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[391/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[392/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[393/517] Linking CXX executable src/bitcoin-wallet
[394/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[395/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
PiRK updated this revision to Diff 32760.Mar 16 2022, 15:10

my regex somehow missed a call

teamcity added a comment.Mar 16 2022, 15:11
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[325/463] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[326/463] Building CXX object src/CMakeFiles/server.dir/rpc/server.cpp.o
[327/463] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[328/463] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[329/463] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[330/463] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[331/463] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[332/463] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[333/463] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[334/463] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[335/463] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[336/463] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[337/463] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[338/463] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
../../src/validation.cpp: In member function ‘bool {anonymous}::MemPoolAccept::PreChecks({anonymous}::MemPoolAccept::ATMPArgs&, {anonymous}::MemPoolAccept::Workspace&)’:
../../src/validation.cpp:472:56: error: cannot convert ‘const Consensus::Params’ to ‘const CBlockIndex*’
             args.m_config.GetChainParams().GetConsensus(), tx, ctxState,
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
In file included from ../../src/validation.cpp:7:
../../src/./validation.h:522:24: note:   initializing argument 1 of ‘bool ContextualCheckTransactionForCurrentBlock(const CBlockIndex*, const Consensus::Params&, const CTransaction&, TxValidationState&, int)’
     const CBlockIndex *active_chain_tip, const Consensus::Params &params,
     ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
[339/463] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[340/463] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[341/463] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[342/463] Linking C static library src/secp256k1/libsecp256k1.a
[343/463] Linking CXX static library src/libcommon.a
[344/463] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[345/463] Linking CXX static library src/libscript.a
[346/463] Linking C executable src/secp256k1/ecmult-bench
[347/463] Linking CXX static library src/libbitcoinconsensus.a
[348/463] Linking C executable src/secp256k1/internal-bench
[349/463] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[350/463] Linking CXX shared library src/libbitcoinconsensus.so.0.25.2
[351/463] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[352/463] Linking CXX executable src/bitcoin-cli
[353/463] Linking C executable src/secp256k1/sign-bench
[354/463] Linking C executable src/secp256k1/verify-bench
[355/463] Linking C executable src/secp256k1/recover-bench
[356/463] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[357/463] Linking CXX executable src/bitcoin-tx
[358/463] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[359/463] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[360/463] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[361/463] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[362/463] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[363/463] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[364/463] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[365/463] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[366/463] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[367/463] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[368/463] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[369/463] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[370/463] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[371/463] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[372/463] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Mar 16 2022, 15:12
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[345/517] Linking C static library src/secp256k1/libsecp256k1.a
[346/517] Linking CXX static library src/libbitcoinconsensus.a
[347/517] Linking C executable src/secp256k1/ecmult-bench
[348/517] Linking C executable src/secp256k1/internal-bench
[349/517] Linking C executable src/secp256k1/sign-bench
[350/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[351/517] Linking C executable src/secp256k1/verify-bench
[352/517] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[353/517] Linking C executable src/secp256k1/recover-bench
[354/517] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[355/517] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[356/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[357/517] Linking CXX static library src/libscript.a
[358/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[359/517] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[360/517] Linking CXX static library src/libcommon.a
[361/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[362/517] Linking CXX shared library src/libbitcoinconsensus.so.0.25.2
[363/517] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[364/517] Linking CXX executable src/bitcoin-cli
[365/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[366/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[367/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[368/517] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[369/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[370/517] Linking CXX executable src/bitcoin-tx
[371/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[372/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[373/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[374/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[375/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[376/517] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[377/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[378/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[379/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[380/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[381/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[382/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[383/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[384/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[385/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[386/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[387/517] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[388/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[389/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[390/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[391/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[392/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[393/517] Linking CXX static library src/wallet/libwallet.a
[394/517] Linking CXX static library src/wallet/libwallet-tool.a
[395/517] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
Harbormaster completed remote builds in B18517: Diff 32760.Mar 16 2022, 15:26
Fabien accepted this revision.Mar 16 2022, 15:40
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
3972 ↗(On Diff #32760)

Out of scope question: is the check against nullptr something we added, or something core removed ? And why ?

This revision is now accepted and ready to land.Mar 16 2022, 15:40
Fabien added a comment.Mar 16 2022, 15:41

@bot build-fuzzer

teamcity awarded a token.Mar 16 2022, 15:42
Closed by commit rABC98315e93d51a: validation: Pass in chain tip to ::ContextualCheckTransactionForCurrentBlock (authored by PiRK). · Explain WhyMar 16 2022, 16:23
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC98315e93d51a: validation: Pass in chain tip to ::ContextualCheckTransactionForCurrentBlock.
PiRK mentioned this in D11205: validation: Check chain tip is non-null in CheckFinalTx.Mar 17 2022, 08:41
PiRK mentioned this in rABC184be66e5c3f: validation: Check chain tip is non-null in CheckFinalTx.Mar 17 2022, 11:10

Revision Contents
Changeset List

PathSize
src/
interfaces/
2 lines
test/
10 lines
3 lines
7 lines
16 lines

Diff 32763

View Options

src/interfaces/chain.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...