validation: Pass in chainstate to CTxMemPool::removeForReorg
ClosedPublic
Actions

Authored by PiRK on Mar 17 2022, 07:58.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4e68502c847a: validation: Pass in chainstate to CTxMemPool::removeForReorg

Summary

Several other parameters are now redundant since they can be safely
obtained from the chainstate given that ::cs_main is locked. These are
now removed.

This is a backport of core#20750 [15/17]
https://github.com/bitcoin/bitcoin/pull/20750/commits/714201881251a787423fbca34f70fed505e9dc28

Depends on D11201

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 17 2022, 07:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2022, 07:58

PiRK requested review of this revision.Mar 17 2022, 07:58

teamcity edited the summary of this revision. (Show Details)Mar 17 2022, 07:58

PiRK added a child revision: D11203: validation: Pass in chainstate to UpdateMempoolForReorg.Mar 17 2022, 08:00

Harbormaster completed remote builds in B18534: Diff 32784.Mar 17 2022, 08:23

Fabien accepted this revision.Mar 17 2022, 09:16

This revision is now accepted and ready to land.Mar 17 2022, 09:16

Closed by commit rABC4e68502c847a: validation: Pass in chainstate to CTxMemPool::removeForReorg (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 17 2022, 11:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4e68502c847a: validation: Pass in chainstate to CTxMemPool::removeForReorg.

Revision Contents
Changeset List

Path

Size

src/

txmempool.h

6 lines

txmempool.cpp

22 lines

Diff 32798

View Options

src/txmempool.h