Page MenuHomePhabricator
Differential D11201

validation: Pass in chain to ::TestLockPointValidity
ClosedPublic
Actions

Authored by PiRK on Mar 17 2022, 07:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa53d338759bf: validation: Pass in chain to ::TestLockPointValidity
Summary

This is a backport of core#20750 [14/17]
https://github.com/bitcoin/bitcoin/pull/20750/commits/71734c65dc491a4bb654ccbb7a1dd0e12131cee4

Depends on D11196

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 17 2022, 07:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2022, 07:57
PiRK requested review of this revision.Mar 17 2022, 07:57
teamcity edited the summary of this revision. (Show Details)Mar 17 2022, 07:57
PiRK added a child revision: D11202: validation: Pass in chainstate to CTxMemPool::removeForReorg.Mar 17 2022, 07:58
Fabien requested changes to this revision.Mar 17 2022, 08:08
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
183 ↗(On Diff #32783)

This can be const ?

This revision now requires changes to proceed.Mar 17 2022, 08:08
Harbormaster completed remote builds in B18533: Diff 32783.Mar 17 2022, 08:12
PiRK updated this revision to Diff 32788.Mar 17 2022, 08:47

make active_chain a const. CChain::Contains is a const method.

Harbormaster completed remote builds in B18538: Diff 32788.Mar 17 2022, 09:04
Fabien accepted this revision.Mar 17 2022, 09:07
This revision is now accepted and ready to land.Mar 17 2022, 09:07
Closed by commit rABCa53d338759bf: validation: Pass in chain to ::TestLockPointValidity (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 17 2022, 11:08
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa53d338759bf: validation: Pass in chain to ::TestLockPointValidity.

Revision Contents
Changeset List

PathSize
src/
2 lines
2 lines
5 lines

Diff 32797

View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...