validation: Check chain tip is non-null in CheckFinalTx
ClosedPublic
Actions

Authored by PiRK on Mar 17 2022, 08:41.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC184be66e5c3f: validation: Check chain tip is non-null in CheckFinalTx

Summary

...also update comments to remove mention of ::ChainActive()

From: https://github.com/bitcoin/bitcoin/pull/20750#discussion_r579400663

Also, what about passing a const reference instead of a pointer? I
know this is only theoretical, but previously if the tip was nullptr,
then Height() evaluated to -1, now it evaluates to UB

Note: in Bitcoin ABC, there was already a check for active_chain_tip == nullptr, but only for nMedianPastTime. A few lines above we accessed the pointer to get the nHeight without checking first (potential UB introduced in D11191).

This is a backport of core#21055 [1/16]
https://github.com/bitcoin/bitcoin/pull/21055/commits/9da106be4db692fa5db7b4de79f9cf7bfef37075

Test Plan

cmake -GNinja .. \
  -DCMAKE_BUILD_TYPE=Debug \
  -DENABLE_SANITIZERS=undefined

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 17 2022, 08:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 17 2022, 08:41

PiRK requested review of this revision.Mar 17 2022, 08:41

teamcity edited the summary of this revision. (Show Details)Mar 17 2022, 08:41

PiRK edited the summary of this revision. (Show Details)Mar 17 2022, 08:42

Harbormaster completed remote builds in B18537: Diff 32787.Mar 17 2022, 08:57

wrong commit

This revision now requires changes to proceed.Mar 17 2022, 09:26

fixed commit

Fabien accepted this revision.Mar 17 2022, 10:51

This revision is now accepted and ready to land.Mar 17 2022, 10:51

Closed by commit rABC184be66e5c3f: validation: Check chain tip is non-null in CheckFinalTx (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 17 2022, 11:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC184be66e5c3f: validation: Check chain tip is non-null in CheckFinalTx.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

16 lines

Diff 32802

View Options

validation: Check chain tip is non-null in CheckFinalTxClosedPublicActions