Page MenuHomePhabricator

validation: CVerifyDB::VerifyDB: Use locking annotation
ClosedPublic

Authored by PiRK on Mar 18 2022, 08:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC00f28a0a45d9: validation: CVerifyDB::VerifyDB: Use locking annotation
Summary

instead of recursively locking unconditionally

This concludes backport of core#21055 [16/16]
https://github.com/bitcoin/bitcoin/pull/21055/commits/e11b6496506246882df450586acf735dabedf731

Depends on D11221

Test Plan

With debug and clang:

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

@bot build-tsan

PiRK published this revision for review.Mar 18 2022, 09:45
Fabien requested changes to this revision.Mar 18 2022, 10:03
Fabien added a subscriber: Fabien.

Please include running with clang and debug in your test plan, tsan won't help here

This revision now requires changes to proceed.Mar 18 2022, 10:03
PiRK requested review of this revision.Mar 18 2022, 10:26
PiRK edited the test plan for this revision. (Show Details)

Run test plan with clang and debug.

This revision is now accepted and ready to land.Mar 18 2022, 10:39