Page MenuHomePhabricator
Differential D11222

validation: CVerifyDB::VerifyDB: Use locking annotation
ClosedPublic
Actions

Authored by PiRK on Mar 18 2022, 08:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC00f28a0a45d9: validation: CVerifyDB::VerifyDB: Use locking annotation
Summary

instead of recursively locking unconditionally

This concludes backport of core#21055 [16/16]
https://github.com/bitcoin/bitcoin/pull/21055/commits/e11b6496506246882df450586acf735dabedf731

Depends on D11221

Test Plan

With debug and clang:

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Mar 18 2022, 08:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2022, 08:41
teamcity edited the summary of this revision. (Show Details)Mar 18 2022, 08:41
PiRK edited the summary of this revision. (Show Details)Mar 18 2022, 08:42

@bot build-tsan

teamcity awarded a token.Mar 18 2022, 08:42
Harbormaster completed remote builds in B18560: Diff 32828.Mar 18 2022, 09:13
PiRK published this revision for review.Mar 18 2022, 09:45
Fabien requested changes to this revision.Mar 18 2022, 10:03
Fabien added a subscriber: Fabien.

Please include running with clang and debug in your test plan, tsan won't help here

This revision now requires changes to proceed.Mar 18 2022, 10:03
PiRK requested review of this revision.Mar 18 2022, 10:26
PiRK edited the test plan for this revision. (Show Details)

Run test plan with clang and debug.

Fabien accepted this revision.Mar 18 2022, 10:39
This revision is now accepted and ready to land.Mar 18 2022, 10:39
Closed by commit rABC00f28a0a45d9: validation: CVerifyDB::VerifyDB: Use locking annotation (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMar 21 2022, 08:50
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC00f28a0a45d9: validation: CVerifyDB::VerifyDB: Use locking annotation.

Revision Contents
Changeset List

PathSize
src/
3 lines
3 lines

Diff 32828

View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...