Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC329ebe963229: tests: add deterministic chain generation unittest fixture

Summary

This is a backport of core#19806 [3/8]
https://github.com/bitcoin/bitcoin/pull/19806/commits/31d225274ff1a4b245aea0a69f0e5224b0e64ca2

Note that the hash of the block in TestChain100Setup is different because Bitcoin ABC blocks have differences with Bitcoin Core blocks.
I added a test that does nothing but initialize a TestChain100DeterministicSetup to demonstrate that the hash in the assertion is correct (changing something in that string makes the test fail).

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18564
Build 36923: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 36922: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 18 2022, 13:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2022, 13:37

PiRK requested review of this revision.Mar 18 2022, 13:37

Harbormaster completed remote builds in B18563: Diff 32840.Mar 18 2022, 13:37

teamcity edited the summary of this revision. (Show Details)Mar 18 2022, 13:37

use uint8

The blockhash in the asssertion probably need to be adjusted for Bitcoin ABC

Harbormaster completed remote builds in B18564: Diff 32841.Mar 18 2022, 14:06

PiRK mentioned this in D11226: txdb: don't reset during in-memory cache resize.Mar 22 2022, 12:36

fix block hash in the assertion in setup_common.h and add a blank test initializing the new test setup to exercise the assertion.

Harbormaster completed remote builds in B18591: Diff 32883.Mar 22 2022, 15:10

Fabien accepted this revision.Mar 23 2022, 08:58

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/test/validation_chainstatemanager_tests.cpp
174 ↗	(On Diff #32883)	Add a dummy `BOOST_CHECK(true);` in this test to avoid a boost warning when no assert is executed from a test case (assert() is not accounted by boost)