Page MenuHomePhabricator
Differential D11235

[Cashtab] Make disabled send button more explicit
ClosedPublic
Actions

Authored by kieran709 on Mar 21 2022, 21:18.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC057a20402da2: [Cashtab] Make disabled send button more explicit
Summary

Related to task T2321. Added light gray color to theme.buttons.secondary.disabledSendBg and replaced the backgroundcolor of SecondaryButton in PrimaryButton.js. SecondaryButton on hover now shows cursor as the universal 'no' sign.

Test Plan

cd web/cashtab && npm start
navigate to send tab
enter a value into the address or amount field which would cause the Send button to be deiabled
observe the light grey background color
hover cursor over the disabled button
observe the cursor switch to the universal no sign

Diff Detail

Repository
rABC Bitcoin ABC
Branch
make-disabled-button-more-obvious
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18601
Build 36993: Build Diffcashtab-tests
Build 36992: arc lint + arc unit

Event Timeline

kieran709 created this revision.Mar 21 2022, 21:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2022, 21:18
kieran709 requested review of this revision.Mar 21 2022, 21:18
kieran709 updated this revision to Diff 32874.

updated snapshots

Harbormaster completed remote builds in B18583: Diff 32873.Mar 21 2022, 21:21
Harbormaster completed remote builds in B18584: Diff 32874.
bytesofman requested changes to this revision.Mar 22 2022, 18:11
bytesofman added inline comments.
web/cashtab/src/assets/styles/theme.js
54 ↗(On Diff #32874)

just call this disabled

This revision now requires changes to proceed.Mar 22 2022, 18:11
kieran709 updated this revision to Diff 32893.Mar 22 2022, 18:35

responding to review feedback

Harbormaster completed remote builds in B18601: Diff 32893.Mar 22 2022, 18:38
bytesofman requested changes to this revision.Mar 22 2022, 18:47

After seeing this, I think the old color is okay -- just the 'universal no' on hover is enough. Please remove the grey bg color. Thanks.

This revision now requires changes to proceed.Mar 22 2022, 18:47
kieran709 updated this revision to Diff 32897.Mar 22 2022, 19:47

responding to review feedback & updating snapshots

Harbormaster completed remote builds in B18604: Diff 32897.Mar 22 2022, 19:50
bytesofman accepted this revision.Mar 22 2022, 20:07
This revision is now accepted and ready to land.Mar 22 2022, 20:07
Closed by commit rABC057a20402da2: [Cashtab] Make disabled send button more explicit (authored by kieran709). · Explain WhyMar 22 2022, 20:26
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC057a20402da2: [Cashtab] Make disabled send button more explicit.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
assets/
styles/
1 line
components/
Common/
4 lines
Configure/
__tests__/
__snapshots__/
Home/
__tests__/
__snapshots__/
Receive/
__tests__/
__snapshots__/
Send/
__tests__/
__snapshots__/

Diff 32893

View Options

web/cashtab/src/assets/styles/theme.js

Loading...
View Options

web/cashtab/src/components/Common/PrimaryButton.js

Loading...
View Options

web/cashtab/src/components/Configure/__tests__/__snapshots__/Configure.test.js.snap

Loading...
View Options

web/cashtab/src/components/Home/__tests__/__snapshots__/Home.test.js.snap

Loading...
View Options

web/cashtab/src/components/Receive/__tests__/__snapshots__/Receive.test.js.snap

Loading...
View Options

web/cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap

Loading...