Page MenuHomePhabricator

[Cashtab] Make disabled send button more explicit
ClosedPublic

Authored by kieran709 on Mar 21 2022, 21:18.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC057a20402da2: [Cashtab] Make disabled send button more explicit
Summary

Related to task T2321. Added light gray color to theme.buttons.secondary.disabledSendBg and replaced the backgroundcolor of SecondaryButton in PrimaryButton.js. SecondaryButton on hover now shows cursor as the universal 'no' sign.

Test Plan

cd web/cashtab && npm start
navigate to send tab
enter a value into the address or amount field which would cause the Send button to be deiabled
observe the light grey background color
hover cursor over the disabled button
observe the cursor switch to the universal no sign

Diff Detail

Repository
rABC Bitcoin ABC
Branch
make-disabled-button-more-obvious
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18584
Build 36959: Build Diffcashtab-tests
Build 36958: arc lint + arc unit

Event Timeline

kieran709 updated this revision to Diff 32874.

updated snapshots

bytesofman added inline comments.
web/cashtab/src/assets/styles/theme.js
54

just call this disabled

This revision now requires changes to proceed.Mar 22 2022, 18:11

responding to review feedback

After seeing this, I think the old color is okay -- just the 'universal no' on hover is enough. Please remove the grey bg color. Thanks.

This revision now requires changes to proceed.Mar 22 2022, 18:47

responding to review feedback & updating snapshots

This revision is now accepted and ready to land.Mar 22 2022, 20:07