Page MenuHomePhabricator
Differential D11241

test: Add tests with maleated snapshot data
ClosedPublic
Actions

Authored by PiRK on Mar 22 2022, 15:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC83ee1128149f: test: Add tests with maleated snapshot data
Summary

https://github.com/bitcoin/bitcoin/pull/19806/commits/769a1ef9fdc9c372f5bbe91d1961cabd60bc1895

test: Add tests with maleated snapshot data

https://github.com/bitcoin/bitcoin/pull/21681/files

validation: fix ActivateSnapshot to use hardcoded nChainTx

validation: remove nchaintx from assumeutxo metadata

Only test related changes for these commits are in this revision

https://github.com/bitcoin/bitcoin/pull/21582/commits/fa8fffebe8ac126f31143619843dd6578a2f4e3c

refactor: Prefer clean assert over UB in coinstats

https://github.com/bitcoin/bitcoin/pull/21582/commits/fa9b74f5ea89624e052934c48391b5076a87ffef

Fix assumeutxo crash due to missing base_blockhash

Only test related changes from this commit are in this revision.

https://github.com/bitcoin/bitcoin/pull/21584/commits/fae33f98e6a8d5934edbdce2eb8688112eac41a8

Fix assumeutxo crash due to invalid base_blockhash

Only test related changes from this commit are in this revision.

This is a backport of core#19806 [7/8] and test related changes from core#21681, core#21582 and core#21584

Depends on D11240

Test Plan

ninja check

With UBSAN:

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 22 2022, 15:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 22 2022, 15:28
PiRK requested review of this revision.Mar 22 2022, 15:28
teamcity edited the summary of this revision. (Show Details)Mar 22 2022, 15:28
Harbormaster completed remote builds in B18597: Diff 32889.Mar 22 2022, 15:52
PiRK edited the summary of this revision. (Show Details)Mar 23 2022, 07:06
PiRK updated this revision to Diff 32910.Mar 23 2022, 10:14

rebase

Harbormaster completed remote builds in B18610: Diff 32910.Mar 23 2022, 10:42
PiRK updated this revision to Diff 32917.Mar 23 2022, 17:33
PiRK edited the summary of this revision. (Show Details)

squash with test changes from core#21681 after squashing the code changes with D11239

Harbormaster completed remote builds in B18615: Diff 32917.Mar 23 2022, 18:28
Fabien accepted this revision.Mar 25 2022, 15:48
This revision is now accepted and ready to land.Mar 25 2022, 15:48
PiRK mentioned this in D11239: simplify ChainstateManager::SnapshotBlockhash() return semantics.Apr 11 2022, 15:23
PiRK updated this revision to Diff 33154.Apr 11 2022, 15:42
PiRK edited the summary of this revision. (Show Details)

squash with new tests for bugfixes (see D11239)

PiRK planned changes to this revision.Apr 11 2022, 15:42
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)Apr 11 2022, 15:44
PiRK updated this revision to Diff 33155.Apr 11 2022, 15:48

add the missing test from core#21584

This revision is now accepted and ready to land.Apr 11 2022, 15:48
Harbormaster completed remote builds in B18783: Diff 33154.Apr 11 2022, 15:57
Harbormaster completed remote builds in B18784: Diff 33155.Apr 11 2022, 16:02
PiRK added a child revision: D11331: refactor: Avoid magic value of all-zeros in assumeutxo base_blockhash.Apr 12 2022, 09:18
PiRK mentioned this in D11240: tests: add snapshot activation test.Apr 12 2022, 09:35
Closed by commit rABC83ee1128149f: test: Add tests with maleated snapshot data (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyApr 13 2022, 06:39
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in rABC03af9518eaa9: simplify ChainstateManager::SnapshotBlockhash() return semantics.
PiRK added a commit: rABC83ee1128149f: test: Add tests with maleated snapshot data.

Revision Contents
Changeset List

PathSize
src/
node/
6 lines
test/
52 lines

Diff 33188

View Options

src/node/coinstats.cpp

Loading...
View Options

src/test/validation_chainstatemanager_tests.cpp

Loading...