Page MenuHomePhabricator
Differential D11331

refactor: Avoid magic value of all-zeros in assumeutxo base_blockhash
ClosedPublic
Actions

Authored by PiRK on Apr 11 2022, 15:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1501283baca2: refactor: Avoid magic value of all-zeros in assumeutxo base_blockhash
Summary

Just use std::optional

This concludes backport of core#21584
https://github.com/bitcoin/bitcoin/pull/21584/commits/fa340b87944764ea4e8e04038fe7471fd452bc23

Depends on D11334 and D11241

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 11 2022, 15:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2022, 15:53
PiRK requested review of this revision.Apr 11 2022, 15:53
teamcity edited the summary of this revision. (Show Details)Apr 11 2022, 15:53
Harbormaster completed remote builds in B18786: Diff 33157.Apr 11 2022, 16:15
Fabien requested changes to this revision.Apr 11 2022, 18:40
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/validation.cpp
4999 ↗(On Diff #33157)

There is a dependency missing: https://github.com/bitcoin/bitcoin/pull/21523 which causes this PR backport to be incomplete

src/validation.h
769 ↗(On Diff #33157)

Unrelated note: the explicit is not very useful here

This revision now requires changes to proceed.Apr 11 2022, 18:40
Fabien mentioned this in D11239: simplify ChainstateManager::SnapshotBlockhash() return semantics.Apr 11 2022, 20:13
Fabien mentioned this in D11240: tests: add snapshot activation test.Apr 11 2022, 20:21
PiRK updated this revision to Diff 33164.Apr 12 2022, 09:14
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D11334: validation: run VerifyDB on all chainstates.

rebase onto D11334, add missing change and add dependency

PiRK edited the summary of this revision. (Show Details)Apr 12 2022, 09:15
PiRK added a parent revision: D11239: simplify ChainstateManager::SnapshotBlockhash() return semantics.
PiRK edited the summary of this revision. (Show Details)Apr 12 2022, 09:18
PiRK added a parent revision: D11241: test: Add tests with maleated snapshot data.
PiRK removed a parent revision: D11239: simplify ChainstateManager::SnapshotBlockhash() return semantics.
Harbormaster completed remote builds in B18790: Diff 33164.Apr 12 2022, 09:33
Fabien accepted this revision.Apr 12 2022, 20:45
This revision is now accepted and ready to land.Apr 12 2022, 20:45
Closed by commit rABC1501283baca2: refactor: Avoid magic value of all-zeros in assumeutxo base_blockhash (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyApr 13 2022, 06:39
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC1501283baca2: refactor: Avoid magic value of all-zeros in assumeutxo base_blockhash.

Revision Contents
Changeset List

Diff 33191

View Options

src/test/validation_chainstatemanager_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...