Page MenuHomePhabricator

[Cashtab] Manually adding contacts
AbandonedPublic

Authored by emack on Apr 11 2022, 02:05.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

As per T2390, an option to manually add a new contact to the contact list.

Built on top of D11266.

Test Plan
  • open cashtab in incognito mode, create new wallet, navigate to Settings and ensure the Contact List dropdown shows an empty list with instructions to either click the New Contact button or to go via the tx history screen's 'Add to contacts' icon.
  • click New Contact and ensure if either of the Name or Address inputs are invalid then the OK button will not progress further until this is corrected
  • enter valid input for both name and address and ensure the OK button results in the successful adding of the contact to the list
  • enter a differet name but the same address as the first contact and ensure the OK button results in a message indicating duplication, with no change to the contact list
  • ensure bitcoincash, simpleledger and etoken addresses are flagged as invalid address inputs
  • send an incoming tx to this wallet, then ensure no regression to the Add to contacts icon routing to the Contact List, with the address added if it didn't already exist

Diff Detail

Repository
rABC Bitcoin ABC
Branch
manualContact
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18804
Build 37399: Build Diffcashtab-tests
Build 37398: arc lint + arc unit