Supersedes D11326
Option to manually add a new contact to contact list.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABCa571cf8c20ac: [Cashtab] Manually adding contacts
- open cashtab in incognito mode, create new wallet, navigate to Settings and ensure the Contact List dropdown shows an empty list with instructions to either click the New Contact button or to go via the tx history screen's 'Add to contacts' icon.
- click New Contact and ensure if either of the Name or Address inputs are invalid then the OK button will not progress further until this is corrected
- enter valid input for both name and address and ensure the OK button results in the successful adding of the contact to the list
- enter a differet name but the same address as the first contact and ensure the OK button results in a message indicating duplication, with no change to the contact list
- ensure bitcoincash, simpleledger and etoken addresses are flagged as invalid address inputs
- send an incoming tx to this wallet, then ensure no regression to the Add to contacts icon routing to the Contact List, with the address added if it didn't already exist
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/cashtab/src/components/Configure/Configure.js | ||
|---|---|---|
| 1246 ↗ | (On Diff #33197) | Need a to param here:  Probably best to not use the <Link> component, instead style a <button> |
Comment Actions
- If it already exists, user should get an error notification
- The 'x' is appearing on top of the msg both here and in the success notifications
Comment Actions
- changed to error notifications for contact duplicates added from Tx History and manual add workflows. The error notification layout itself mitigates the 'x' appearing on top of the duplication message
- adjusted generalNotification usage to mitigate the overlapping 'x' on success messages