Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCa571cf8c20ac: [Cashtab] Manually adding contacts

Summary

Supersedes D11326

Option to manually add a new contact to contact list.

Test Plan

open cashtab in incognito mode, create new wallet, navigate to Settings and ensure the Contact List dropdown shows an empty list with instructions to either click the New Contact button or to go via the tx history screen's 'Add to contacts' icon.
click New Contact and ensure if either of the Name or Address inputs are invalid then the OK button will not progress further until this is corrected
enter valid input for both name and address and ensure the OK button results in the successful adding of the contact to the list
enter a differet name but the same address as the first contact and ensure the OK button results in a message indicating duplication, with no change to the contact list
ensure bitcoincash, simpleledger and etoken addresses are flagged as invalid address inputs
send an incoming tx to this wallet, then ensure no regression to the Add to contacts icon routing to the Contact List, with the address added if it didn't already exist

Diff Detail

Repository

rABC Bitcoin ABC

Branch

manualContact2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18866
Build 37518: Build Diff	cashtab-tests
Build 37517: arc lint + arc unit

Event Timeline

emack created this revision.Apr 13 2022, 11:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2022, 11:00

emack requested review of this revision.Apr 13 2022, 11:00

emack mentioned this in D11326: [Cashtab] Manually adding contacts.Apr 13 2022, 11:00

Harbormaster completed remote builds in B18809: Diff 33197.Apr 13 2022, 11:02

bytesofman requested changes to this revision.Apr 14 2022, 09:34

bytesofman added inline comments.

web/cashtab/src/components/Configure/Configure.js
1246 ↗	(On Diff #33197)	Need a `to` param here: Probably best to not use the `<Link>` component, instead style a `<button>`

This revision now requires changes to proceed.Apr 14 2022, 09:34

Using styled button instead of Link

Harbormaster completed remote builds in B18828: Diff 33224.Apr 14 2022, 12:45

bytesofman requested changes to this revision.Apr 20 2022, 17:13

bytesofman added inline comments.

web/cashtab/src/components/Configure/Configure.js
329 ↗	(On Diff #33224)	Use a styled component here instead of the generic.
1373 ↗	(On Diff #33224)	Make this a styled component

This revision now requires changes to proceed.Apr 20 2022, 17:13

Updates to contact list button as a styled component

Harbormaster completed remote builds in B18855: Diff 33268.Apr 21 2022, 11:12

If it already exists, user should get an error notification
The 'x' is appearing on top of the msg both here and in the success notifications

This revision now requires changes to proceed.Apr 21 2022, 20:04

changed to error notifications for contact duplicates added from Tx History and manual add workflows. The error notification layout itself mitigates the 'x' appearing on top of the duplication message
adjusted generalNotification usage to mitigate the overlapping 'x' on success messages

Harbormaster completed remote builds in B18864: Diff 33282.Apr 21 2022, 23:55

Adjusted Manual Add button position and fixed post-merge conditional rendering bug

Harbormaster completed remote builds in B18866: Diff 33284.Apr 22 2022, 00:02

bytesofman accepted this revision.Apr 22 2022, 03:36

This revision is now accepted and ready to land.Apr 22 2022, 03:36

Closed by commit rABCa571cf8c20ac: [Cashtab] Manually adding contacts (authored by emack). · Explain WhyApr 22 2022, 04:41

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABCa571cf8c20ac: [Cashtab] Manually adding contacts.