HomePhabricator

[Cashtab] Manually adding contacts

Description

[Cashtab] Manually adding contacts

Summary:
Supersedes D11326

Option to manually add a new contact to contact list.

Test Plan:

  • open cashtab in incognito mode, create new wallet, navigate to Settings and ensure the Contact List dropdown shows an empty list with instructions to either click the New Contact button or to go via the tx history screen's 'Add to contacts' icon.
  • click New Contact and ensure if either of the Name or Address inputs are invalid then the OK button will not progress further until this is corrected
  • enter valid input for both name and address and ensure the OK button results in the successful adding of the contact to the list
  • enter a differet name but the same address as the first contact and ensure the OK button results in a message indicating duplication, with no change to the contact list
  • ensure bitcoincash, simpleledger and etoken addresses are flagged as invalid address inputs
  • send an incoming tx to this wallet, then ensure no regression to the Add to contacts icon routing to the Contact List, with the address added if it didn't already exist

Reviewers: bytesofman, #bitcoin_abc

Reviewed By: bytesofman, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D11345

Details

Provenance
emackAuthored on Apr 13 2022, 10:57
emackPushed on Apr 22 2022, 04:41
Reviewer
Restricted Project
Differential Revision
D11345: [Cashtab] Manually adding contacts
Parents
rABCfbf44f39082b: [Cashtab] Export contact list
Branches
Unknown
Tags
Unknown