Differential D11329

[avalanche] Consistently use the FromHex methods in tests
ClosedPublic
Actions

Authored by Fabien on Apr 11 2022, 13:53.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC2af086eb7a6d: [avalanche] Consistently use the FromHex methods in tests

Summary

This has a few benefits:

It removes the dependency to streams.h
It prevents the tests running into a meaningless exception in the input stream is invalid
It makes it easier to update to new format in the future

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_fromhex_tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18777
Build 37345: Build Diff	build-without-wallet · lint-circular-dependencies · build-debug · build-clang · build-clang-tidy · build-diff
Build 37344: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 11 2022, 13:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2022, 13:53

Fabien requested review of this revision.Apr 11 2022, 13:53

Harbormaster completed remote builds in B18777: Diff 33147.Apr 11 2022, 14:07

PiRK accepted this revision.Apr 11 2022, 14:10

This revision is now accepted and ready to land.Apr 11 2022, 14:10

Closed by commit rABC2af086eb7a6d: [avalanche] Consistently use the FromHex methods in tests (authored by Fabien). · Explain WhyApr 11 2022, 14:15

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2af086eb7a6d: [avalanche] Consistently use the FromHex methods in tests.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

delegation_tests.cpp

30 lines

proof_tests.cpp

6 lines

Diff 33147

src/avalanche/test/delegation_tests.cpp

Loading...

src/avalanche/test/proof_tests.cpp

Loading...