Page MenuHomePhabricator

Add an option to allow for bypassing the network group limit on outbound connections
ClosedPublic

Authored by Fabien on Apr 12 2022, 19:53.

Details

Summary

This hidden option is intended for testing purpose only. It makes it possible to bypass the network group limitation for outbound connection, designed to prevent from connecting to several peers located in the same area and as such helps preventing eclipse attacks. This new flag comes in handy when running tests in a semi private network made of nodes located at the same place. There is no change of behavior when the flag is not set.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien requested review of this revision.Apr 12 2022, 19:53
tyler-smith added a subscriber: tyler-smith.

This flag will be useful and the implementation looks correct.

This revision is now accepted and ready to land.Apr 13 2022, 00:38
sdulfari added inline comments.
src/init.cpp
399 ↗(On Diff #33195)

In post review, I find this comment to have aged poorly (example: D11390) I don't think this comment belongs here, but rather where the arg is used.