Page MenuHomePhabricator

[avalanche] Always send an avahello message if we have a proof

Authored by Fabien on Apr 15 2022, 10:58.



This diff removes the filter so we can send avahello messages to peers that don't set the avalanche service bit. This has several benefits:

  • It is less code and less edge cases. Peers with avalanche disabled will simply ignore the message.
  • It makes it possible for a node with avalanche turned on but no proof to poll the network (but it will not be polled, it's kind of a read only mode).
  • It removes the need to broadcast our local proof entirely, leading to further simplification, because sending an avahello is equivalent to sending an inv with our proofid.

Depends on D11363 (otherwise the node will get banned by non avalanche peers).
Reverts D11280 which is no longer needed.

Test Plan
ninja all check-all

Diff Detail

rABC Bitcoin ABC
Lint Passed
No Test Coverage
Build Status
Buildable 18835
Build 37460: Build Diffbuild-without-wallet · lint-circular-dependencies · build-diff · build-clang-tidy · build-debug · build-clang
Build 37459: arc lint + arc unit