Differential D11367

[avalanche] Account for our own proof in the connected stake computation
ClosedPublic
Actions

Authored by Fabien on Apr 15 2022, 13:33.

Details

Reviewers

tyler-smith

Group Reviewers

Restricted Project

Commits

rABCc314aec7e585: [avalanche] Account for our own proof in the connected stake computation

Summary

If we are not connected to another node using our proof, account for a connection anyway as long as our proof is bound to a peer.

Depends on D11366.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_local_proof_connected_score

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18838
Build 37466: Build Diff	build-clang · build-diff · build-clang-tidy · build-debug · lint-circular-dependencies · build-without-wallet
Build 37465: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 15 2022, 13:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2022, 13:33

Fabien requested review of this revision.Apr 15 2022, 13:33

Harbormaster completed remote builds in B18838: Diff 33236.Apr 15 2022, 13:45

Looks correct other than a small comment typo.

src/avalanche/test/processor_tests.cpp
1275	Typo: 'se' -> 'so'

This revision is now accepted and ready to land.Apr 19 2022, 05:30

tyler-smith mentioned this in D11369: [avalanche] Make quorum detection consider local proofs..Apr 19 2022, 05:31

Closed by commit rABCc314aec7e585: [avalanche] Account for our own proof in the connected stake computation (authored by Fabien). · Explain WhyApr 19 2022, 07:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc314aec7e585: [avalanche] Account for our own proof in the connected stake computation.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

12 lines

test/

processor_tests.cpp

52 lines

Diff 33236

View Options

src/avalanche/processor.cpp