Page MenuHomePhabricator
Differential D11376

[WEBSITE] Add the new IFP address to the upgrade page
ClosedPublic
Actions

Authored by Fabien on Apr 21 2022, 12:46.

Details

Reviewers
bytesofman
Mengerian
Group Reviewers
Restricted Project
Commits
rABCWEBa096840c692d: [WEBSITE] Add the new IFP address to the upgrade page
Summary

Right now the address is only readable in the code, which is not very convenient for pool operators.

Test Plan
bundle exec jekyll serve --incremental

Check the address is correct and the code block looks good with various screen sizes.

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
new_ifp_address
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 18857
Build 37501: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 21 2022, 12:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 21 2022, 12:46
Fabien requested review of this revision.Apr 21 2022, 12:46
Harbormaster completed remote builds in B18857: Diff 33270.Apr 21 2022, 12:46
bytesofman requested changes to this revision.Apr 21 2022, 17:35
bytesofman added a subscriber: bytesofman.

Rendering issue for widths below 450px:

450px:

image.png (367×497 px, 58 KB)

320px:

image.png (762×379 px, 80 KB)

I think the best available solution is to word wrap the address, which still preserves the original string and doesn't add extra characters like a -.

e.g.

<code style="overflow-wrap: break-word;">ecash:prfhcnyqnl5cgrnmlfmms675w93ld7mvvqd0y8lz07</code>

gives:

image.png (674×375 px, 84 KB)

upgrade.html
15

Add style="overflow-wrap: break-word;" to the opening <code> tag

This revision now requires changes to proceed.Apr 21 2022, 17:35
Fabien edited the test plan for this revision. (Show Details)Apr 22 2022, 08:40

Good catch and thanks for the hint.

Fabien updated this revision to Diff 33286.Apr 22 2022, 08:41

Fix overflow wrapping of the address for smaller screens

Harbormaster completed remote builds in B18867: Diff 33286.Apr 22 2022, 08:41
bytesofman accepted this revision.Apr 22 2022, 16:27
This revision is now accepted and ready to land.Apr 22 2022, 16:27
Mengerian accepted this revision.Apr 22 2022, 21:39
Mengerian added a subscriber: Mengerian.

Looks good to me too.

Closed by commit rABCWEBa096840c692d: [WEBSITE] Add the new IFP address to the upgrade page (authored by Fabien). · Explain WhyApr 23 2022, 08:17
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCWEBa096840c692d: [WEBSITE] Add the new IFP address to the upgrade page.

Revision Contents
Changeset List

PathSize
2 lines

Diff 33270

View Options

upgrade.html

Loading...