Page MenuHomePhabricator

[avalanche] Answer getavaproofs message with short proof ids
ClosedPublic

Authored by Fabien on Apr 26 2022, 23:31.

Details

Summary

This diff introduces a new getavaproofs message, which which requests for an avaproofs message containing all the proofs short ids from the peer.

Notes:

  • The name does not contain the "compact" mention like one might expect, due to the limitation in the command name to 12 chars.
  • There is a theoretical limit of 21 millions proofs which could cause the node to generate a oversized message (limited to 2MiB). This will be taken care in a follow-up.

Depends on D11453.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

src/net_processing.cpp
5317 ↗(On Diff #33318)

I could not lock before the forEach call without triggering clang safety analysis, not sure why

tyler-smith added inline comments.
test/functional/abc_p2p_proof_inventory.py
204 ↗(On Diff #33318)

Maybe I'm misunderstanding but if the avahello counts as 1, shouldn't receiving_peer.proof_invs_counter be 1 and not 0?

deadalnix added inline comments.
src/net_processing.cpp
5324 ↗(On Diff #33318)

Presumably, the size of the inventory set will not shrink, so this should bail early, somehow.

5329 ↗(On Diff #33318)

This approach is a bit questionable. Why not send a compact block like structure? This doesn't sound that much more difficult that what is done here.

Fabien planned changes to this revision.Apr 27 2022, 13:13
Fabien retitled this revision from [avalanche] Answer getavaproofs message with proof id inventories to [WIP][avalanche] Answer getavaproofs message with short proof ids.
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)

Putting up for early review but needs to be rebased to get rid of the ProofElement dependency.

sdulfari requested changes to this revision.May 12 2022, 21:07
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/net_processing.cpp
3426 ↗(On Diff #33501)

AVAPROOFS?

This revision now requires changes to proceed.May 12 2022, 21:07
src/net_processing.cpp
3426 ↗(On Diff #33501)

There is no code for handling it yet so it's not an issue

Fabien retitled this revision from [WIP][avalanche] Answer getavaproofs message with short proof ids to [avalanche] Answer getavaproofs message with short proof ids.May 17 2022, 09:21
Fabien edited the summary of this revision. (Show Details)
sdulfari requested changes to this revision.May 17 2022, 16:53
sdulfari added inline comments.
test/functional/abc_p2p_proof_inventory.py
203

At a minimum, assert_equal(len(proofids), 50). Otherwise it's possible for this test to pass if proofids is somehow empty.

And that suggests another test case that should exist: getavaproofs to a peer with no proofs should return an empty avaproofs message.

212

Isn't the timeout too short to be reliable on CI?

This revision now requires changes to proceed.May 17 2022, 16:53
This revision is now accepted and ready to land.May 18 2022, 17:59

Tail of the build log:

2863 warnings and 1 error generated.
Error while processing /work/abc-ci-builds/build-clang-tidy/../../src/test/util/net.cpp.
Suppressed 2863 warnings (2863 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
[365/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-11;-warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=../../src/test/util/setup_common.cpp -- /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -c ../../src/test/util/setup_common.cpp
../../src/./net.h:656:9: error: no template named 'RadixTree' [clang-diagnostic-error]
        RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
        ^
3016 warnings and 1 error generated.
Error while processing /work/abc-ci-builds/build-clang-tidy/../../src/test/util/setup_common.cpp.
Suppressed 3016 warnings (3016 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
[366/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[367/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[368/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[369/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[370/518] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[371/518] Linking CXX executable src/bitcoin-tx
[372/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[373/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[374/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[375/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[376/518] Linking CXX static library src/zmq/libzmq.a
[377/518] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[378/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/cmake -E __run_co_compile --launcher=/usr/bin/ccache --tidy="/usr/bin/clang-tidy-11;-warnings-as-errors=*;--extra-arg-before=--driver-mode=g++" --source=../../src/seeder/bitcoin.cpp -- /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c ../../src/seeder/bitcoin.cpp
../../src/./net.h:656:9: error: no template named 'RadixTree' [clang-diagnostic-error]
        RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
        ^
2923 warnings and 1 error generated.
Error while processing /work/abc-ci-builds/build-clang-tidy/../../src/seeder/bitcoin.cpp.
Suppressed 2923 warnings (2923 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
[379/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[380/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[381/518] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[382/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[383/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[384/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[385/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[386/518] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[387/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[388/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[389/518] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[390/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[391/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[392/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[393/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[394/518] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[395/518] Linking CXX static library src/wallet/libwallet.a
[396/518] Linking CXX static library src/wallet/libwallet-tool.a
[397/518] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Tail of the build log:

[364/520] Linking C executable src/secp256k1/recover-bench
[365/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[366/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[367/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[368/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -c ../../src/test/util/setup_common.cpp
In file included from ../../src/test/util/setup_common.cpp:17:
../../src/./net.h:656:9: error: no template named 'RadixTree'
        RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
        ^
1 error generated.
[369/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/net.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/net.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/net.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/net.cpp.o -c ../../src/test/util/net.cpp
In file included from ../../src/test/util/net.cpp:5:
In file included from ../../src/./test/util/net.h:9:
../../src/./net.h:656:9: error: no template named 'RadixTree'
        RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
        ^
1 error generated.
[370/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[371/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[372/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[373/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[374/520] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[375/520] Linking CXX executable src/bitcoin-tx
[376/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[377/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[378/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[379/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[380/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[381/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[382/520] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[383/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[384/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[385/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[386/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c ../../src/seeder/bitcoin.cpp
In file included from ../../src/seeder/bitcoin.cpp:13:
In file included from ../../src/./seeder/messagewriter.h:9:
../../src/./net.h:656:9: error: no template named 'RadixTree'
        RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
        ^
1 error generated.
[387/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[388/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[389/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[390/520] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[391/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[392/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[393/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[394/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[395/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[396/520] Linking CXX static library src/wallet/libwallet.a
[397/520] Linking CXX static library src/wallet/libwallet-tool.a
[398/520] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Tail of the build log:

[361/520] Linking CXX static library src/libcommon.a
[362/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[363/520] Linking CXX shared library src/libbitcoinconsensus.so.0.25.6
[364/520] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[365/520] Linking CXX executable src/bitcoin-cli
[366/520] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[367/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[368/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[369/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/net.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/net.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/net.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/net.cpp.o -c ../../src/test/util/net.cpp
In file included from ../../src/./test/util/net.h:9,
                 from ../../src/test/util/net.cpp:5:
../../src/./net.h:656:9: error: ‘RadixTree’ does not name a type
         RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
         ^~~~~~~~~
[370/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[371/520] Linking CXX executable src/bitcoin-tx
[372/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[373/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[374/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[375/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[376/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -c ../../src/test/util/setup_common.cpp
In file included from ../../src/test/util/setup_common.cpp:17:
../../src/./net.h:656:9: error: ‘RadixTree’ does not name a type
         RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
         ^~~~~~~~~
[377/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[378/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[379/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[380/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[381/520] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[382/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[383/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[384/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[385/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c ../../src/seeder/bitcoin.cpp
In file included from ../../src/./seeder/messagewriter.h:9,
                 from ../../src/seeder/bitcoin.cpp:13:
../../src/./net.h:656:9: error: ‘RadixTree’ does not name a type
         RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
         ^~~~~~~~~
[386/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[387/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[388/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[389/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[390/520] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[391/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[392/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[393/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[394/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[395/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[396/520] Linking CXX static library src/wallet/libwallet.a
[397/520] Linking CXX static library src/wallet/libwallet-tool.a
[398/520] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Tail of the build log:

[361/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[362/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[363/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[364/520] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[365/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[366/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[367/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/net.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/net.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/net.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/net.cpp.o -c ../../src/test/util/net.cpp
In file included from ../../src/./test/util/net.h:9,
                 from ../../src/test/util/net.cpp:5:
../../src/./net.h:656:9: error: ‘RadixTree’ does not name a type
         RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
         ^~~~~~~~~
[368/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[369/520] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[370/520] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[371/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[372/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[373/520] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[374/520] Linking CXX static library src/libscript.a
[375/520] Linking CXX static library src/libcommon.a
[376/520] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -c ../../src/test/util/setup_common.cpp
In file included from ../../src/test/util/setup_common.cpp:17:
../../src/./net.h:656:9: error: ‘RadixTree’ does not name a type
         RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
         ^~~~~~~~~
[377/520] Linking CXX shared library src/libbitcoinconsensus.so.0.25.6
[378/520] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[379/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[380/520] Linking CXX executable src/bitcoin-cli
[381/520] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[382/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[383/520] Linking CXX executable src/bitcoin-tx
[384/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c ../../src/seeder/bitcoin.cpp
In file included from ../../src/./seeder/messagewriter.h:9,
                 from ../../src/seeder/bitcoin.cpp:13:
../../src/./net.h:656:9: error: ‘RadixTree’ does not name a type
         RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
         ^~~~~~~~~
[385/520] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[386/520] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[387/520] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[388/520] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[389/520] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[390/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[391/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[392/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[393/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[394/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[395/520] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[396/520] Linking CXX static library src/wallet/libwallet.a
[397/520] Linking CXX static library src/wallet/libwallet-tool.a
[398/520] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Tail of the build log:

[345/466] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[346/466] Linking C static library src/secp256k1/libsecp256k1.a
[347/466] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c ../../src/validation.cpp
In file included from ../../src/./avalanche/processor.h:16,
                 from ../../src/validation.cpp:11:
../../src/./net.h:656:9: error: ‘RadixTree’ does not name a type
         RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
         ^~~~~~~~~
[348/466] Linking C executable src/secp256k1/ecmult-bench
[349/466] Linking C executable src/secp256k1/internal-bench
[350/466] Linking C executable src/secp256k1/sign-bench
[351/466] Linking CXX static library src/libcommon.a
[352/466] Linking C executable src/secp256k1/verify-bench
[353/466] Linking C executable src/secp256k1/recover-bench
[354/466] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[355/466] Linking CXX static library src/libscript.a
[356/466] Linking CXX static library src/libbitcoinconsensus.a
[357/466] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[358/466] Linking CXX shared library src/libbitcoinconsensus.so.0.25.6
[359/466] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[360/466] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[361/466] Linking CXX executable src/bitcoin-cli
[362/466] Linking CXX executable src/bitcoin-tx
[363/466] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[364/466] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[365/466] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[366/466] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/net.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/net.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/net.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/net.cpp.o -c ../../src/test/util/net.cpp
In file included from ../../src/./test/util/net.h:9,
                 from ../../src/test/util/net.cpp:5:
../../src/./net.h:656:9: error: ‘RadixTree’ does not name a type
         RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
         ^~~~~~~~~
[367/466] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[368/466] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[369/466] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[370/466] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
FAILED: src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -MF src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o.d -o src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o -c ../../src/seeder/bitcoin.cpp
In file included from ../../src/./seeder/messagewriter.h:9,
                 from ../../src/seeder/bitcoin.cpp:13:
../../src/./net.h:656:9: error: ‘RadixTree’ does not name a type
         RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
         ^~~~~~~~~
[371/466] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
FAILED: src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -MF src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o.d -o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o -c ../../src/test/util/setup_common.cpp
In file included from ../../src/test/util/setup_common.cpp:17:
../../src/./net.h:656:9: error: ‘RadixTree’ does not name a type
         RadixTree<const avalanche::Proof, avalanche::ProofRadixTreeAdapter>
         ^~~~~~~~~
[372/466] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[373/466] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[374/466] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[375/466] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Serialize/deserialize the prefilled proofs in the test framework

Fabien planned changes to this revision.May 30 2022, 18:52

Fix prefilled proofs serialization/deserialization

This revision is now accepted and ready to land.May 30 2022, 20:19