Page MenuHomePhabricator
Differential D11389

[avalanche] Send getavalancheproofs request upon receipt of a new valid proof
AbandonedPublic
Actions

Authored by Fabien on Apr 26 2022, 23:32.

Details

Reviewers
tyler-smith
deadalnix
Group Reviewers
Restricted Project
Summary

If we got a valid new proof from one of our peer, then it might have others. In this case the node requests them by sending a getavaproofs message.

Depends on D11388.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_send_getavaproofs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18895
Build 37573: Build Diffbuild-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-clang
Build 37572: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 26 2022, 23:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 26 2022, 23:32
Fabien requested review of this revision.Apr 26 2022, 23:32
Harbormaster completed remote builds in B18895: Diff 33319.Apr 26 2022, 23:55
tyler-smith accepted this revision.Apr 27 2022, 10:52
tyler-smith added a subscriber: tyler-smith.

Looks good. Left a comment to consider but not something that should hold up this changeset.

src/net_processing.cpp
5285

Sending a new GETAVAPROOFS every time we see a new interesting proof seems non-ideal. Is there a good existing mechanism to coalesce multiple potential responses?

This revision is now accepted and ready to land.Apr 27 2022, 10:52
deadalnix requested changes to this revision.Apr 27 2022, 12:13
deadalnix added a subscriber: deadalnix.

This is O(n^2)

This revision now requires changes to proceed.Apr 27 2022, 12:13
Fabien abandoned this revision.Jun 10 2022, 22:48

Revision Contents
Changeset List

PathSize
src/
8 lines
test/
functional/
39 lines

Diff 33319

View Options

src/net_processing.cpp

Loading...
View Options

test/functional/abc_p2p_proof_inventory.py

Loading...