Page MenuHomePhabricator
Differential D11410

[Cashtab] Airdrop modal percentage color patch
ClosedPublic
Actions

Authored by kieran709 on May 4 2022, 17:54.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC82e236211536: [Cashtab] Airdrop modal percentage color patch
Summary

Related to task T2436. Loading percentage in Airdrop modal text should be lightGrey.

Test Plan

cd web/cashtab && npm start
navigate to airdrop screen and paste eToken id
or
navigate to eToken information screen and click 'airdrop xec to holders'
input an amount of XEC to be calculated
observe that the percent text near the progress bar is lightGrey instead of black

Diff Detail

Repository
rABC Bitcoin ABC
Branch
loading-percent-font-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18950
Build 37665: Build Diffcashtab-tests
Build 37664: arc lint + arc unit

Event Timeline

kieran709 created this revision.May 4 2022, 17:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 4 2022, 17:54
kieran709 requested review of this revision.May 4 2022, 17:54
Harbormaster completed remote builds in B18937: Diff 33388.May 4 2022, 17:57
bytesofman requested changes to this revision.May 4 2022, 23:25
bytesofman added inline comments.
web/cashtab/src/components/Airdrop/Airdrop.js
83 ↗(On Diff #33388)

After seeing this -- let's go with white instead of light grey

This revision now requires changes to proceed.May 4 2022, 23:25
kieran709 updated this revision to Diff 33402.May 5 2022, 14:50

responding to review feedback

Harbormaster completed remote builds in B18950: Diff 33402.May 5 2022, 14:53
bytesofman accepted this revision.May 5 2022, 17:02
This revision is now accepted and ready to land.May 5 2022, 17:02
Closed by commit rABC82e236211536: [Cashtab] Airdrop modal percentage color patch (authored by kieran709). · Explain WhyMay 5 2022, 18:42
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC82e236211536: [Cashtab] Airdrop modal percentage color patch.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Airdrop/
9 lines

Diff 33402

View Options

web/cashtab/src/components/Airdrop/Airdrop.js

Loading...