Page MenuHomePhabricator

[avalanche] Rename the `Invalid` vote status for consistency with other status
AbandonedPublic

Authored by Fabien on May 5 2022, 09:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

As per title, the vote is not invalid, but the outcome is that it invalidated the item being voted on.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_rename_invalid_vote_status
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18942
Build 37652: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 37651: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.May 5 2022, 19:45
deadalnix added a subscriber: deadalnix.

They are all adjective, I don't see any of this is consistent, and in fact, Invalidated imply that they were made invalid at some point in the past, which may not be the case at all (they might always have been invalid, for instance, and therefore, never invalidated).

This diff is the essence of confusing motion for progress.

This revision now requires changes to proceed.May 5 2022, 19:45

I'm not dying on that hill