net_processing: move some globals into PeerManagerImpl
ClosedPublic
Actions

Authored by PiRK on May 6 2022, 15:46.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC2e470f884524: net_processing: move some globals into PeerManagerImpl

Summary

nSyncStarted, mapBlockSource, g_outbound_peers_with_protect_from_disconnect were all only used by PeerManagerImpl methods already.

Changes related to g_wtxid_relay_peers are not present because these are for segwit.

This is a backport of core#20942 [1/9]
https://github.com/bitcoin/bitcoin/pull/20942/commits/9781c08a33569370f191b30cc7e2ce9b5317eb3e

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 6 2022, 15:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2022, 15:46

PiRK requested review of this revision.May 6 2022, 15:46

teamcity edited the summary of this revision. (Show Details)May 6 2022, 15:46

PiRK added a child revision: D11434: net_processing: move AlreadyHaveTx into PeerManageImpl.May 6 2022, 15:48

Harbormaster completed remote builds in B18973: Diff 33437.May 6 2022, 15:57

Maybe mention in the summary that changes related to g_wtxid_relay_peers are not present because these are for segwit.

This revision is now accepted and ready to land.May 6 2022, 23:39

Thanks. Summary updated with the suggested note.

Closed by commit rABC2e470f884524: net_processing: move some globals into PeerManagerImpl (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyMay 10 2022, 15:13

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2e470f884524: net_processing: move some globals into PeerManagerImpl.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

39 lines

Diff 33456

View Options

net_processing: move some globals into PeerManagerImplClosedPublicActions