Page MenuHomePhabricator

net_processing: move some globals into PeerManagerImpl
ClosedPublic

Authored by PiRK on May 6 2022, 15:46.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC2e470f884524: net_processing: move some globals into PeerManagerImpl
Summary

nSyncStarted, mapBlockSource, g_outbound_peers_with_protect_from_disconnect were all only used by PeerManagerImpl methods already.

Changes related to g_wtxid_relay_peers are not present because these are for segwit.

This is a backport of core#20942 [1/9]
https://github.com/bitcoin/bitcoin/pull/20942/commits/9781c08a33569370f191b30cc7e2ce9b5317eb3e

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.May 6 2022, 15:46
sdulfari added a subscriber: sdulfari.

Maybe mention in the summary that changes related to g_wtxid_relay_peers are not present because these are for segwit.

This revision is now accepted and ready to land.May 6 2022, 23:39

Thanks. Summary updated with the suggested note.