Page MenuHomePhabricator
Differential D11434

net_processing: move AlreadyHaveTx into PeerManageImpl
ClosedPublic
Actions

Authored by PiRK on May 6 2022, 15:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC77d90e8d8e93: net_processing: move AlreadyHaveTx into PeerManageImpl
Summary

Allows making recentRejects and g_recent_confirmed_transactions members rather than globals, and remove need to pass mempool as argument.

This is a backport of core#20942 [2&3/9]
https://github.com/bitcoin/bitcoin/pull/20942/commits/eeac5062508c98fe58daaec471cdd27f3909b6ec#
https://github.com/bitcoin/bitcoin/pull/20942/commits/052d9bc7e52aea373a316f08d42460ead4ed16c8

Depends on D11433

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 6 2022, 15:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2022, 15:48
PiRK requested review of this revision.May 6 2022, 15:48
teamcity edited the summary of this revision. (Show Details)May 6 2022, 15:48
PiRK added a child revision: D11435: net_processing: move MarkBlockAs*, TipMayBeStale, FindNextBlocksToDL to PeerManagerImpl.May 6 2022, 15:51
Harbormaster completed remote builds in B18974: Diff 33438.May 6 2022, 16:08
Fabien accepted this revision.May 9 2022, 09:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net_processing.cpp
766 ↗(On Diff #33438)

You should move this one as well in a follow up

This revision is now accepted and ready to land.May 9 2022, 09:44
Closed by commit rABC77d90e8d8e93: net_processing: move AlreadyHaveTx into PeerManageImpl (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyMay 10 2022, 15:13
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC77d90e8d8e93: net_processing: move AlreadyHaveTx into PeerManageImpl.

Revision Contents
Changeset List

PathSize
src/
89 lines

Diff 33457

View Options

src/net_processing.cpp

Loading...