Differential D11452

[avalanche] Fix logging of vote statuses
ClosedPublic
Actions

Authored by sdulfari on May 12 2022, 06:34.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC8e43311b0101: [avalanche] Fix logging of vote statuses

Summary

Fallthrough is causing all vote statuses to show "finalized" in the logs.

This patch fixes it and actually checks the logs for a status other than finalized in a test.

Test Plan

This can be run with only the patch to the test to see that it fails or with the full patch
to see the issue is now fixed:

ninja bitcoind && ./test/functional/test_runner.py abc_p2p_avalanche_voting.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

vote-status-log-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19007
Build 37770: Build Diff	build-without-wallet · build-clang · lint-circular-dependencies · build-diff · build-clang-tidy · build-debug
Build 37769: arc lint + arc unit

Event Timeline

sdulfari created this revision.May 12 2022, 06:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2022, 06:34

sdulfari requested review of this revision.May 12 2022, 06:34

Harbormaster completed remote builds in B19007: Diff 33491.May 12 2022, 06:50

Fabien accepted this revision.May 12 2022, 06:53

This revision is now accepted and ready to land.May 12 2022, 06:53

Closed by commit rABC8e43311b0101: [avalanche] Fix logging of vote statuses (authored by sdulfari). · Explain WhyMay 12 2022, 16:57

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC8e43311b0101: [avalanche] Fix logging of vote statuses.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

4 lines

test/

functional/

abc_p2p_avalanche_voting.py

3 lines

Diff 33491

View Options

src/net_processing.cpp