[Cashtab] [chronik] Add hash160 strings to wallet state
ClosedPublic
Actions

Authored by bytesofman on May 17 2022, 16:50.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC43e1c094449c: [Cashtab] [chronik] Add hash160 strings to wallet state

Summary

T2447

Chronik requires hash160 to get utxo info for an address.

This diff adds hash160 to wallet state so it is available throughout the app.

Test Plan

npm start
Check local forage by opening dev console --> Application --> indexedDb
Note that hash160 is listed in Path145, Path245, and Path1899 objects under wallet
Activate a different wallet
Confirm the same

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.May 17 2022, 16:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 17 2022, 16:50

bytesofman requested review of this revision.May 17 2022, 16:50

Harbormaster completed remote builds in B19061: Diff 33560.May 17 2022, 16:53

Looks good - I'll add a task to find a library to carry out this hash160 conversion to replace the current api call towards the tail end of the chronikfication initiative.

This revision is now accepted and ready to land.May 20 2022, 00:18

In D11478#257561, @emack wrote:

Looks good - I'll add a task to find a library to carry out this hash160 conversion to replace the current api call towards the tail end of the chronikfication initiative.

While we do want to deprecate bch-js, this is at least not an api call

https://github.com/Permissionless-Software-Foundation/bch-js/blob/master/src/address.js#L205

so -- it's something we want in xec-js.

Closed by commit rABC43e1c094449c: [Cashtab] [chronik] Add hash160 strings to wallet state (authored by bytesofman). · Explain WhyMay 20 2022, 16:47

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC43e1c094449c: [Cashtab] [chronik] Add hash160 strings to wallet state.