Paths

Table of Contentst

Differential D11504

Revert "miner: Pass in chainstate to BlockAssembler::CreateNewBlock"
AbandonedPublic
Actions

Authored by PiRK on May 20 2022, 10:54.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Summary

This reverts commit rABCd1b32162feaf. The following commit will make chainstate a member variable.

This is a partial backport of core#21525
https://github.com/bitcoin/bitcoin/pull/21525/commits/0c1b2bc549aec77b247f0103652d883227841ac5
https://github.com/bitcoin/bitcoin/pull/21525/commits/eede0647b06b6009080c4e536a2705e911d6ee19
https://github.com/bitcoin/bitcoin/pull/21525/commits/e62067e7bcad5a559899afff2e4a8e8b7e9f4301

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19116
Build 37980: Build Diff	build-diff · lint-circular-dependencies · build-without-wallet · build-debug · build-clang · build-clang-tidy
Build 37979: arc lint + arc unit

Event Timeline

PiRK created this revision.May 20 2022, 10:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2022, 10:54

PiRK requested review of this revision.May 20 2022, 10:54

teamcity edited the summary of this revision. (Show Details)May 20 2022, 10:54

PiRK added a child revision: D11505: miner: Add chainstate member to BlockAssembler.May 20 2022, 10:55

Harbormaster completed remote builds in B19116: Diff 33637.May 20 2022, 11:10

There is no need to break things before fixing them.

This revision now requires changes to proceed.May 20 2022, 13:32

PiRK mentioned this in D11505: miner: Add chainstate member to BlockAssembler.May 20 2022, 15:20

PiRK removed a child revision: D11505: miner: Add chainstate member to BlockAssembler.May 20 2022, 16:55

abandoned in favor of D11505

Revision Contents
Changeset List

Path

Size

src/

miner.h

2 lines

miner.cpp

11 lines

rpc/

mining.cpp

8 lines

test/

blockfilter_index_tests.cpp

3 lines

miner_tests.cpp

54 lines

util/

mining.cpp

8 lines

setup_common.cpp

5 lines

validation_block_tests.cpp

4 lines

Diff 33637

View Options

src/miner.h

View Options

src/miner.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/util/mining.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/test/validation_block_tests.cpp

Revert "miner: Pass in chainstate to BlockAssembler::CreateNewBlock"AbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33637

src/miner.h

src/miner.cpp

src/rpc/mining.cpp

src/test/blockfilter_index_tests.cpp

src/test/miner_tests.cpp

src/test/util/mining.cpp

src/test/util/setup_common.cpp

src/test/validation_block_tests.cpp

Revert "miner: Pass in chainstate to BlockAssembler::CreateNewBlock"
AbandonedPublic
Actions

Revision Contents
Changeset List