Page MenuHomePhabricator
Differential D11511

rpc/mining: Use existing NodeContext
ClosedPublic
Actions

Authored by PiRK on May 21 2022, 12:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3ff0431d429c: rpc/mining: Use existing NodeContext
Summary

Also pass in appropriate object to:

  • GetNetworkHashPS
  • [gG]enerateBlock{,s}

Also:

  • Misc style/constness changes

This is a partial backport of core#21391
Depends on D11507
https://github.com/bitcoin/bitcoin/pull/21391/commits/60dc05afc6f6388c6f86729a0edd7cb69f1748e0

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 21 2022, 12:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2022, 12:33
PiRK requested review of this revision.May 21 2022, 12:33
teamcity edited the summary of this revision. (Show Details)May 21 2022, 12:34
Harbormaster completed remote builds in B19130: Diff 33655.May 21 2022, 12:47
PiRK added a child revision: D11512: rpc/rawtx: Use existing NodeContext.May 21 2022, 12:50
Fabien requested changes to this revision.May 23 2022, 12:51
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/mining.cpp
486 ↗(On Diff #33655)
1148 ↗(On Diff #33655)
This revision now requires changes to proceed.May 23 2022, 12:51
PiRK updated this revision to Diff 33666.May 23 2022, 14:50

address review

Harbormaster completed remote builds in B19137: Diff 33666.May 23 2022, 15:05
Fabien accepted this revision.May 23 2022, 15:34
This revision is now accepted and ready to land.May 23 2022, 15:34
Closed by commit rABC3ff0431d429c: rpc/mining: Use existing NodeContext (authored by PiRK). · Explain WhyMay 23 2022, 15:49
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3ff0431d429c: rpc/mining: Use existing NodeContext.

Revision Contents
Changeset List

PathSize
src/
rpc/
85 lines

Diff 33673

View Options

src/rpc/mining.cpp

Loading...