Page MenuHomePhabricator

rpc/mining: Use existing NodeContext
ClosedPublic

Authored by PiRK on May 21 2022, 12:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3ff0431d429c: rpc/mining: Use existing NodeContext
Summary

Also pass in appropriate object to:

  • GetNetworkHashPS
  • [gG]enerateBlock{,s}

Also:

  • Misc style/constness changes

This is a partial backport of core#21391
Depends on D11507
https://github.com/bitcoin/bitcoin/pull/21391/commits/60dc05afc6f6388c6f86729a0edd7cb69f1748e0

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.May 21 2022, 12:33
Fabien requested changes to this revision.May 23 2022, 12:51
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/mining.cpp
486 ↗(On Diff #33655)
1148 ↗(On Diff #33655)
This revision now requires changes to proceed.May 23 2022, 12:51
This revision is now accepted and ready to land.May 23 2022, 15:34
This revision was automatically updated to reflect the committed changes.